Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays
@ 2026-07-20  6:23 Uwe Kleine-König (The Capable Hub)
  2026-07-20  6:23 ` [PATCH v2 1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
  2026-07-27 23:12 ` [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-20  6:23 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
	AngeloGioacchino Del Regno, Charles Keepax, Kuninori Morimoto,
	linux-sound, linux-kernel, linux-arm-kernel, linux-mediatek,
	linux-renesas-soc, Vijendar Mukunda, Venkata Prasad Potturu,
	Bard Liao, Syed Saba Kareem, Aaron Ma, Mark Pearson, Hasun Park,
	Krzysztof Kozlowski, Kees Cook, Cezary Rojewski,
	Cristian Ciocaltea, Mario Limonciello, Guilherme G. Piccoli,
	James Ogletree, Fred Treven, Ben Bright, David Rhodes,
	Richard Fitzgerald, Peter Ujfalusi, Kai Vehmanen,
	Pierre-Louis Bossart, Maciej Strozek, Mac Chiang,
	Ranjani Sridharan, patches, Lars-Peter Clausen, Nuno Sá,
	Srinivas Kandagatla, Shengjiu Wang, Xiubo Li, Fabio Estevam,
	Nicolin Chen, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Sylwester Nawrocki, Amadeusz Sławiński, linux-arm-msm,
	linuxppc-dev, imx

Hello,

the objective of this series is still to prepare making struct
platform_device_id::driver_data an anonymous union. See
https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
for the details about that.

If you consider the last patch mostly churn, just drop it.

v1 of this series can be found at
https://lore.kernel.org/linux-sound/cover.1779958164.git.u.kleine-koenig@baylibre.com.

Changes since then:

 - Rebase to current next
 - Some grammar improvements in the commit log for patch #1
 - Split the changes to sound/soc/amd/acp in separate changes.
 - The 2nd patch used to be "ASoC: renesas: fsi: Simplify driver_data
   handling" which removed fsi_id_table[0].driver_data, but with commit
   38d3273075d6 ("ASoC: renesas: fsi: remove platform data style
   support") that needed to change.
 - The last patch now touches a few more files. (I didn't check if these
   are new offenders or if I failed to catch them in v1.) I didn't add
   Cezary Rojewski's ack because of that.

If splitting off the amd/acp changes was requested because they go in
via a separate tree: That's possible, in fact each file is touched only
once, so the patches can be reordered freely and applied via different
trees if needed.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (6):
  ASoC: codecs: mt6357: Drop unused assignment of platform_device_id
    driver data
  ASoC: renesas: fsi: Drop platform probing metadata
  ASoC: amd: acp: Use named initializers for platform_device_id arrays
  ASoC: amd: acp: Unify code style for platform_device_id array
  ASoC: Use named initializers for platform_device_id arrays
  ASOC: Unify code style for platform_device_id arrays

 sound/soc/amd/acp/acp-sdw-legacy-mach.c |  4 ++--
 sound/soc/amd/acp/acp-sdw-sof-mach.c    |  4 ++--
 sound/soc/amd/acp/acp-sof-mach.c        | 14 +++++++-------
 sound/soc/au1x/db1200.c                 |  2 +-
 sound/soc/codecs/adau7118-hw.c          |  2 +-
 sound/soc/codecs/bt-sco.c               | 10 +++-------
 sound/soc/codecs/cs40l50-codec.c        |  4 ++--
 sound/soc/codecs/cs42l43.c              |  4 ++--
 sound/soc/codecs/mt6357.c               |  4 ++--
 sound/soc/codecs/wcd934x.c              |  6 ++----
 sound/soc/fsl/imx-pcm-rpmsg.c           |  6 +++---
 sound/soc/intel/avs/boards/da7219.c     |  6 ++----
 sound/soc/intel/avs/boards/dmic.c       |  6 ++----
 sound/soc/intel/avs/boards/es8336.c     |  6 ++----
 sound/soc/intel/avs/boards/hdaudio.c    |  6 ++----
 sound/soc/intel/avs/boards/i2s_test.c   |  6 ++----
 sound/soc/intel/avs/boards/max98357a.c  |  6 ++----
 sound/soc/intel/avs/boards/max98373.c   |  6 ++----
 sound/soc/intel/avs/boards/max98927.c   |  6 ++----
 sound/soc/intel/avs/boards/nau8825.c    |  6 ++----
 sound/soc/intel/avs/boards/pcm3168a.c   |  6 ++----
 sound/soc/intel/avs/boards/probe.c      |  2 +-
 sound/soc/intel/avs/boards/rt274.c      |  2 +-
 sound/soc/intel/avs/boards/rt286.c      |  2 +-
 sound/soc/intel/avs/boards/rt298.c      |  2 +-
 sound/soc/intel/avs/boards/rt5514.c     |  2 +-
 sound/soc/intel/avs/boards/rt5640.c     |  2 +-
 sound/soc/intel/avs/boards/rt5663.c     |  2 +-
 sound/soc/intel/avs/boards/rt5682.c     |  2 +-
 sound/soc/intel/avs/boards/ssm4567.c    |  2 +-
 sound/soc/intel/boards/sof_sdw.c        |  4 ++--
 sound/soc/renesas/fsi.c                 |  4 ++--
 sound/soc/samsung/i2s.c                 |  2 +-
 33 files changed, 61 insertions(+), 87 deletions(-)


base-commit: 0718283ab28bc3907e10b61a6b4be6fefa1cbb2f
-- 
2.55.0.11.g153666a7d9bb



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data
  2026-07-20  6:23 [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
@ 2026-07-20  6:23 ` Uwe Kleine-König (The Capable Hub)
  2026-07-27 23:12 ` [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-20  6:23 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
	AngeloGioacchino Del Regno, Charles Keepax, Kuninori Morimoto,
	linux-sound, linux-kernel, linux-arm-kernel, linux-mediatek

The driver explicitly sets the .driver_data member of struct
platform_device_id to zero without relying on that value. Drop this
unused assignment.

While touching this array unify spacing, use a named initializer for
.name and drop a trailing comma after the list terminator.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 sound/soc/codecs/mt6357.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/mt6357.c b/sound/soc/codecs/mt6357.c
index 674cf7df9df4..3b07087e1cab 100644
--- a/sound/soc/codecs/mt6357.c
+++ b/sound/soc/codecs/mt6357.c
@@ -1834,8 +1834,8 @@ static int mt6357_platform_driver_probe(struct platform_device *pdev)
 }
 
 static const struct platform_device_id mt6357_platform_ids[] = {
-	{"mt6357-sound", 0},
-	{ /* sentinel */ },
+	{ .name = "mt6357-sound" },
+	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(platform, mt6357_platform_ids);
 
-- 
2.55.0.11.g153666a7d9bb



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays
  2026-07-20  6:23 [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
  2026-07-20  6:23 ` [PATCH v2 1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
@ 2026-07-27 23:12 ` Mark Brown
  2026-07-30 10:42   ` Cezary Rojewski
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2026-07-27 23:12 UTC (permalink / raw)
  To: Liam Girdwood, Uwe Kleine-König (The Capable Hub)
  Cc: Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
	AngeloGioacchino Del Regno, Charles Keepax, Kuninori Morimoto,
	linux-sound, linux-kernel, linux-arm-kernel, linux-mediatek,
	linux-renesas-soc, Vijendar Mukunda, Venkata Prasad Potturu,
	Bard Liao, Syed Saba Kareem, Aaron Ma, Mark Pearson, Hasun Park,
	Krzysztof Kozlowski, Kees Cook, Cezary Rojewski,
	Cristian Ciocaltea, Mario Limonciello, Guilherme G. Piccoli,
	James Ogletree, Fred Treven, Ben Bright, David Rhodes,
	Richard Fitzgerald, Peter Ujfalusi, Kai Vehmanen,
	Pierre-Louis Bossart, Maciej Strozek, Mac Chiang,
	Ranjani Sridharan, patches, Lars-Peter Clausen, Nuno Sá,
	Srinivas Kandagatla, Shengjiu Wang, Xiubo Li, Fabio Estevam,
	Nicolin Chen, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Sylwester Nawrocki, Amadeusz Sławiński, linux-arm-msm,
	linuxppc-dev, imx

On Mon, 20 Jul 2026 08:23:44 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> ASoC: Use named initializers for platform_device_id arrays
> 
> Hello,
> 
> the objective of this series is still to prepare making struct
> platform_device_id::driver_data an anonymous union. See
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the details about that.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data
      https://git.kernel.org/broonie/sound/c/c7a6909de856
[2/6] ASoC: renesas: fsi: Drop platform probing metadata
      https://git.kernel.org/broonie/sound/c/0ca8f65516a9
[3/6] ASoC: amd: acp: Use named initializers for platform_device_id arrays
      https://git.kernel.org/broonie/sound/c/2b26d06fd3d8
[4/6] ASoC: amd: acp: Unify code style for platform_device_id array
      https://git.kernel.org/broonie/sound/c/4bed1074db1e
[5/6] ASoC: Use named initializers for platform_device_id arrays
      https://git.kernel.org/broonie/sound/c/232725a0e386
[6/6] ASOC: Unify code style for platform_device_id arrays
      https://git.kernel.org/broonie/sound/c/e4dc03df1f71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays
  2026-07-27 23:12 ` [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Mark Brown
@ 2026-07-30 10:42   ` Cezary Rojewski
  0 siblings, 0 replies; 4+ messages in thread
From: Cezary Rojewski @ 2026-07-30 10:42 UTC (permalink / raw)
  To: Mark Brown
  Cc: Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
	AngeloGioacchino Del Regno, Charles Keepax, Kuninori Morimoto,
	linux-sound, linux-kernel, linux-arm-kernel, linux-mediatek,
	linux-renesas-soc, Vijendar Mukunda, Venkata Prasad Potturu,
	Bard Liao, Syed Saba Kareem, Aaron Ma, Mark Pearson, Hasun Park,
	Krzysztof Kozlowski, Kees Cook, Cristian Ciocaltea,
	Mario Limonciello, Guilherme G. Piccoli, James Ogletree,
	Fred Treven, Ben Bright, David Rhodes, Richard Fitzgerald,
	Peter Ujfalusi, Kai Vehmanen, Pierre-Louis Bossart,
	Maciej Strozek, Mac Chiang, Ranjani Sridharan, patches,
	Lars-Peter Clausen, Nuno Sá, Srinivas Kandagatla,
	Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Sylwester Nawrocki,
	Amadeusz Sławiński, linux-arm-msm, linuxppc-dev, imx,
	Liam Girdwood, Uwe Kleine-König (The Capable Hub)

On 7/28/2026 1:12 AM, Mark Brown wrote:
> On Mon, 20 Jul 2026 08:23:44 +0200, Uwe Kleine-König (The Capable Hub) wrote:
>> ASoC: Use named initializers for platform_device_id arrays
>>
>> Hello,
>>
>> the objective of this series is still to prepare making struct
>> platform_device_id::driver_data an anonymous union. See
>> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
>> for the details about that.
>>
>> [...]
> 
> Applied to
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
> 
> Thanks!
> 
> [1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data
>        https://git.kernel.org/broonie/sound/c/c7a6909de856
> [2/6] ASoC: renesas: fsi: Drop platform probing metadata
>        https://git.kernel.org/broonie/sound/c/0ca8f65516a9
> [3/6] ASoC: amd: acp: Use named initializers for platform_device_id arrays
>        https://git.kernel.org/broonie/sound/c/2b26d06fd3d8
> [4/6] ASoC: amd: acp: Unify code style for platform_device_id array
>        https://git.kernel.org/broonie/sound/c/4bed1074db1e
> [5/6] ASoC: Use named initializers for platform_device_id arrays
>        https://git.kernel.org/broonie/sound/c/232725a0e386
> [6/6] ASOC: Unify code style for platform_device_id arrays
>        https://git.kernel.org/broonie/sound/c/e4dc03df1f71

I'd at least expect my Acked-by: tag replaced with Reviewed-by: for the 
AMD's patch 4/6. Perhaps it does not matter in a long run but I feel 
better pointing this out (it has been pointed during the review).

Kind regards,
Czarek


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-07-30 10:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-20  6:23 [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-20  6:23 ` [PATCH v2 1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-27 23:12 ` [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Mark Brown
2026-07-30 10:42   ` Cezary Rojewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox