Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"A.s. Dong" <aisheng.dong@nxp.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, ",
	linux-arm-kernel"@lists.infradead.org,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>, ",
	Sascha Hauer" <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	linux-mediatek@lists.infradead.org,
	Shawn Guo <shawnguo@kernel.org>,
	srv_heupstream <linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support
Date: Thu, 26 Jul 2018 12:57:25 +0200	[thread overview]
Message-ID: <ddd25683-d7a6-e900-461f-9bbac3100579@pengutronix.de> (raw)
In-Reply-To: <CABb+yY0kVFvQRBrU4j9t=_JcSUkcXMMSK5u=XSufM6XcmKiv-g@mail.gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1161 bytes --]



On 26.07.2018 11:49, Jassi Brar wrote:
> On Thu, Jul 26, 2018 at 12:23 PM, Oleksij Rempel
> <o.rempel@pengutronix.de> wrote:
> 
>> Each MU has four pairs of rx/tx data register with four rx/tx interrupts
>> which can also be used as a separate channel.
>>
> So the hardware actually supports 4 channels.
> 
>> -- #mbox-cells:  Must be 0. Number of cells in a mailbox
>> +- #mbox-cells:  Must be:
>> +               0 - for single channel mode. i.MX8* SCU protocol specific.
>> +               1 - for multichannel (generic) mode.
>> +
> No, please.
> DT bindings should reflect the real hardware, and not the software
> mode we want the driver to work in.
> Please define mbox-cells=1  and have the i.MX8* platform always ask
> for channel-0.

We spend already some week to publicly talk about this..
The problem is, imx8 has multiple MUs, only some of them communicate
directly with SCU. SCU has some well defined protocol and
MU should be used and configured in some SCU specific way. From NXP
perspective, SCU firmware should not be replaceable and from Linux side
seen as part of the HW.

@Dong, is it correct description?


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2018-07-26 10:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180726065331.6186-1-o.rempel@pengutronix.de>
     [not found] ` <20180726065331.6186-7-o.rempel@pengutronix.de>
     [not found]   ` <CABb+yY1Fbj2GiO_zjwnvNFutjX_fRpxnuEoeu6Z3s4NAv2ugbg@mail.gmail.com>
2018-07-26 10:51     ` [PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit Oleksij Rempel
2018-07-26 11:09       ` Jassi Brar
2018-07-26 11:42         ` Oleksij Rempel
2018-07-26 12:17           ` Jassi Brar
     [not found] ` <20180726065331.6186-4-o.rempel@pengutronix.de>
     [not found]   ` <CABb+yY0kVFvQRBrU4j9t=_JcSUkcXMMSK5u=XSufM6XcmKiv-g@mail.gmail.com>
2018-07-26 10:57     ` Oleksij Rempel [this message]
2018-07-26 11:28       ` [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support Jassi Brar
     [not found]     ` <AM0PR04MB42116C756EC78AD12EB254D6802B0@AM0PR04MB4211.eurprd04.prod.outlook.com>
     [not found]       ` <CABb+yY0yn9os6nqH8eUfAr3Q3ev4=TfpTp=5ZDBR7FN67eb-wg@mail.gmail.com>
     [not found]         ` <VI1PR04MB4222672B8F7B6AF2B11A4442802A0@VI1PR04MB4222.eurprd04.prod.outlook.com>
     [not found]           ` <CABb+yY1EkHk85H72xYoYA3JbQL03+-o3UcRVdA_Zub-Q+D=OHw@mail.gmail.com>
     [not found]             ` <VI1PR04MB422216469EE5F3ED8E53A4F1802A0@VI1PR04MB4222.eurprd04.prod.outlook.com>
     [not found]               ` <CABb+yY0SfdFr8TMOMosTVb5+LFWqB8nQkKj3ze8usi-s7Cko4g@mail.gmail.com>
     [not found]                 ` <VI1PR04MB4222B4877B341C0FA07A6A8D802A0@VI1PR04MB4222.eurprd04.prod.outlook.com>
     [not found]                   ` <CABb+yY1MSSQKZ6BOQXC-x=qy4VZ5HqDBjmh_BJTXSkAm3+P8mA@mail.gmail.com>
2018-07-30  7:35                     ` Oleksij Rempel
2018-07-30  8:42                       ` A.s. Dong
2018-07-30 13:04                       ` Jassi Brar
2018-07-30 14:14                         ` A.s. Dong
2018-07-30 14:27                           ` A.s. Dong
2018-07-30 14:17                         ` A.s. Dong
2018-07-30 14:44                         ` Oleksij Rempel
2018-07-30 15:02                           ` Jassi Brar
2018-07-30 15:36                             ` A.s. Dong
2018-07-30 16:18                             ` Jassi Brar
2018-07-30 16:49                               ` Oleksij Rempel
2018-07-31  2:51                                 ` Jassi Brar
2018-07-31  7:21                               ` A.s. Dong
2018-07-31 10:15                                 ` Jassi Brar
2018-07-31 12:42                                   ` Jassi Brar
2018-08-02  9:24                                     ` A.s. Dong
2018-08-09  2:22                                       ` A.s. Dong
2018-08-09  2:55                                         ` Jassi Brar
2018-08-09  6:45                                           ` A.s. Dong
     [not found] ` <20180726065331.6186-5-o.rempel@pengutronix.de>
     [not found]   ` <CABb+yY32vBy5qVYsQ6u45=rV6gEggqKy3Jqn1B4oWHaGfTyQ8Q@mail.gmail.com>
     [not found]     ` <1532601691.32306.28.camel@pengutronix.de>
     [not found]       ` <CABb+yY1GEmw_8q2HaF8y5VfFJX_c_0_MbWtPUE_j_o-zS8iZ_g@mail.gmail.com>
2018-07-26 11:44         ` [PATCH v7 4/6] dt-bindings: mailbox: imx-mu: add i.MX6SX and i.MX7S SoCs Vladimir Zapolskiy
2018-07-26 11:52           ` Jassi Brar
2018-07-26 11:55             ` Vladimir Zapolskiy
2018-07-26 12:10               ` Jassi Brar
     [not found]                 ` <CABb+yY02KNB9ELKiWYdB0LyvTghhk+nk-dTUGfG8_+KUB_H=Mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-26 12:41                   ` Vladimir Zapolskiy
     [not found]         ` <1532604937.32306.30.camel@pengutronix.de>
     [not found]           ` <CABb+yY0LbLfK2SEdTeuDmaGc+PsVn0AREQ=E=c4UZgxa5K95qQ@mail.gmail.com>
2018-07-26 11:51             ` Vladimir Zapolskiy
2018-07-26 12:00               ` Jassi Brar
2018-07-26 12:10                 ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddd25683-d7a6-e900-461f-9bbac3100579@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=", linux-arm-kernel"@lists.infradead.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox