* [PATCH 0/2] Add CMDQ driver support for mt8188 @ 2023-12-15 2:35 Jason-JH.Lin 2023-12-15 2:35 ` [PATCH 1/2] mailbox: mtk-cmdq: Sort cmdq platform data by compatible name Jason-JH.Lin 2023-12-15 2:35 ` [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 Jason-JH.Lin 0 siblings, 2 replies; 6+ messages in thread From: Jason-JH.Lin @ 2023-12-15 2:35 UTC (permalink / raw) To: Jassi Brar, Chun-Kuang Hu, AngeloGioacchino Del Regno Cc: Matthias Brugger, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, Jeffrey Kardatzke, Jason-ch Chen, Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung, Jason-jh Lin From: Jason-jh Lin <jason-jh.lin@mediatek.corp-partner.google.com> Since mt8188 has 32 GCE HW thread, we nedd a new platform data to support it. So we sort the platform data in numerical order of compatible names and add a new mt8188 platform data. Jason-JH.Lin (2): mailbox: mtk-cmdq: Sort cmdq platform data by compatible name mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 drivers/mailbox/mtk-cmdq-mailbox.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- 2.18.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] mailbox: mtk-cmdq: Sort cmdq platform data by compatible name 2023-12-15 2:35 [PATCH 0/2] Add CMDQ driver support for mt8188 Jason-JH.Lin @ 2023-12-15 2:35 ` Jason-JH.Lin 2023-12-15 2:47 ` CK Hu (胡俊光) 2023-12-15 2:35 ` [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 Jason-JH.Lin 1 sibling, 1 reply; 6+ messages in thread From: Jason-JH.Lin @ 2023-12-15 2:35 UTC (permalink / raw) To: Jassi Brar, Chun-Kuang Hu, AngeloGioacchino Del Regno Cc: Matthias Brugger, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, Jeffrey Kardatzke, Jason-ch Chen, Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung Sort cmdq platform data according to the number sequence of compatible names. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index de862e9137d5..76e5f762628c 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -750,10 +750,10 @@ static const struct gce_plat gce_plat_v7 = { }; static const struct of_device_id cmdq_of_ids[] = { + {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4}, {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2}, {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3}, {.compatible = "mediatek,mt8186-gce", .data = (void *)&gce_plat_v7}, - {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4}, {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v5}, {.compatible = "mediatek,mt8195-gce", .data = (void *)&gce_plat_v6}, {} -- 2.18.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mailbox: mtk-cmdq: Sort cmdq platform data by compatible name 2023-12-15 2:35 ` [PATCH 1/2] mailbox: mtk-cmdq: Sort cmdq platform data by compatible name Jason-JH.Lin @ 2023-12-15 2:47 ` CK Hu (胡俊光) 0 siblings, 0 replies; 6+ messages in thread From: CK Hu (胡俊光) @ 2023-12-15 2:47 UTC (permalink / raw) To: jassisinghbrar@gmail.com, Jason-JH Lin (林睿祥), chunkuang.hu@kernel.org, angelogioacchino.delregno@collabora.com Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Singo Chang (張興國), Johnson Wang (王聖鑫), Jason-ch Chen (陳建豪), Shawn Sung (宋孝謙), Nancy Lin (林欣螢), jkardatzke@google.com, Project_Global_Chrome_Upstream_Group, linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com On Fri, 2023-12-15 at 10:35 +0800, Jason-JH.Lin wrote: > Sort cmdq platform data according to the number sequence of > compatible names. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > index de862e9137d5..76e5f762628c 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -750,10 +750,10 @@ static const struct gce_plat gce_plat_v7 = { > }; > > static const struct of_device_id cmdq_of_ids[] = { > + {.compatible = "mediatek,mt6779-gce", .data = (void > *)&gce_plat_v4}, > {.compatible = "mediatek,mt8173-gce", .data = (void > *)&gce_plat_v2}, > {.compatible = "mediatek,mt8183-gce", .data = (void > *)&gce_plat_v3}, > {.compatible = "mediatek,mt8186-gce", .data = (void > *)&gce_plat_v7}, > - {.compatible = "mediatek,mt6779-gce", .data = (void > *)&gce_plat_v4}, > {.compatible = "mediatek,mt8192-gce", .data = (void > *)&gce_plat_v5}, > {.compatible = "mediatek,mt8195-gce", .data = (void > *)&gce_plat_v6}, > {} ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 2023-12-15 2:35 [PATCH 0/2] Add CMDQ driver support for mt8188 Jason-JH.Lin 2023-12-15 2:35 ` [PATCH 1/2] mailbox: mtk-cmdq: Sort cmdq platform data by compatible name Jason-JH.Lin @ 2023-12-15 2:35 ` Jason-JH.Lin 2023-12-15 2:47 ` CK Hu (胡俊光) 1 sibling, 1 reply; 6+ messages in thread From: Jason-JH.Lin @ 2023-12-15 2:35 UTC (permalink / raw) To: Jassi Brar, Chun-Kuang Hu, AngeloGioacchino Del Regno Cc: Matthias Brugger, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, Jeffrey Kardatzke, Jason-ch Chen, Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung Add CMDQ driver support for mt8188 by adding its compatible and driver data in CMDQ driver. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 76e5f762628c..612b9feb258a 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -749,11 +749,19 @@ static const struct gce_plat gce_plat_v7 = { .gce_num = 1 }; +static const struct gce_plat gce_plat_v8 = { + .thread_nr = 32, + .shift = 3, + .control_by_sw = true, + .gce_num = 2 +}; + static const struct of_device_id cmdq_of_ids[] = { {.compatible = "mediatek,mt6779-gce", .data = (void *)&gce_plat_v4}, {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2}, {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3}, {.compatible = "mediatek,mt8186-gce", .data = (void *)&gce_plat_v7}, + {.compatible = "mediatek,mt8188-gce", .data = (void *)&gce_plat_v8}, {.compatible = "mediatek,mt8192-gce", .data = (void *)&gce_plat_v5}, {.compatible = "mediatek,mt8195-gce", .data = (void *)&gce_plat_v6}, {} -- 2.18.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 2023-12-15 2:35 ` [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 Jason-JH.Lin @ 2023-12-15 2:47 ` CK Hu (胡俊光) 2023-12-15 3:06 ` Jason-JH Lin (林睿祥) 0 siblings, 1 reply; 6+ messages in thread From: CK Hu (胡俊光) @ 2023-12-15 2:47 UTC (permalink / raw) To: jassisinghbrar@gmail.com, Jason-JH Lin (林睿祥), chunkuang.hu@kernel.org, angelogioacchino.delregno@collabora.com Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Singo Chang (張興國), Johnson Wang (王聖鑫), Jason-ch Chen (陳建豪), Shawn Sung (宋孝謙), Nancy Lin (林欣螢), jkardatzke@google.com, Project_Global_Chrome_Upstream_Group, linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com Hi, Jason: On Fri, 2023-12-15 at 10:35 +0800, Jason-JH.Lin wrote: > Add CMDQ driver support for mt8188 by adding its compatible and > driver data in CMDQ driver. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > index 76e5f762628c..612b9feb258a 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -749,11 +749,19 @@ static const struct gce_plat gce_plat_v7 = { > .gce_num = 1 > }; > > +static const struct gce_plat gce_plat_v8 = { > + .thread_nr = 32, > + .shift = 3, > + .control_by_sw = true, > + .gce_num = 2 > +}; > + > static const struct of_device_id cmdq_of_ids[] = { > {.compatible = "mediatek,mt6779-gce", .data = (void > *)&gce_plat_v4}, > {.compatible = "mediatek,mt8173-gce", .data = (void > *)&gce_plat_v2}, > {.compatible = "mediatek,mt8183-gce", .data = (void > *)&gce_plat_v3}, > {.compatible = "mediatek,mt8186-gce", .data = (void > *)&gce_plat_v7}, > + {.compatible = "mediatek,mt8188-gce", .data = (void > *)&gce_plat_v8}, I think 'v8' is not trivial for anyone. Every SoC has each setting, so I would like the name to directly show the SoC name, such as 'gce_plat_mt8188'. So does other SoC. Regards, CK > {.compatible = "mediatek,mt8192-gce", .data = (void > *)&gce_plat_v5}, > {.compatible = "mediatek,mt8195-gce", .data = (void > *)&gce_plat_v6}, > {} ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 2023-12-15 2:47 ` CK Hu (胡俊光) @ 2023-12-15 3:06 ` Jason-JH Lin (林睿祥) 0 siblings, 0 replies; 6+ messages in thread From: Jason-JH Lin (林睿祥) @ 2023-12-15 3:06 UTC (permalink / raw) To: CK Hu (胡俊光), jassisinghbrar@gmail.com, chunkuang.hu@kernel.org, angelogioacchino.delregno@collabora.com Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Singo Chang (張興國), Johnson Wang (王聖鑫), Jason-ch Chen (陳建豪), Shawn Sung (宋孝謙), Nancy Lin (林欣螢), jkardatzke@google.com, Project_Global_Chrome_Upstream_Group, linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com Hi CK, Thanks for the reviews. On Fri, 2023-12-15 at 02:47 +0000, CK Hu (胡俊光) wrote: > Hi, Jason: > > On Fri, 2023-12-15 at 10:35 +0800, Jason-JH.Lin wrote: > > Add CMDQ driver support for mt8188 by adding its compatible and > > driver data in CMDQ driver. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > > b/drivers/mailbox/mtk-cmdq-mailbox.c > > index 76e5f762628c..612b9feb258a 100644 > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > @@ -749,11 +749,19 @@ static const struct gce_plat gce_plat_v7 = { > > .gce_num = 1 > > }; > > > > +static const struct gce_plat gce_plat_v8 = { > > + .thread_nr = 32, > > + .shift = 3, > > + .control_by_sw = true, > > + .gce_num = 2 > > +}; > > + > > static const struct of_device_id cmdq_of_ids[] = { > > {.compatible = "mediatek,mt6779-gce", .data = (void > > *)&gce_plat_v4}, > > {.compatible = "mediatek,mt8173-gce", .data = (void > > *)&gce_plat_v2}, > > {.compatible = "mediatek,mt8183-gce", .data = (void > > *)&gce_plat_v3}, > > {.compatible = "mediatek,mt8186-gce", .data = (void > > *)&gce_plat_v7}, > > + {.compatible = "mediatek,mt8188-gce", .data = (void > > *)&gce_plat_v8}, > > I think 'v8' is not trivial for anyone. Every SoC has each setting, > so > I would like the name to directly show the SoC name, such as > 'gce_plat_mt8188'. So does other SoC. > OK, I'll add a patch to modify gce_plat postfix from 'v1~v7' to the SoC names. Then add 'gce_plat_mt8188' for mt8188. Regards, Jason-JH.Lin > Regards, > CK > > > {.compatible = "mediatek,mt8192-gce", .data = (void > > *)&gce_plat_v5}, > > {.compatible = "mediatek,mt8195-gce", .data = (void > > *)&gce_plat_v6}, > > {} ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-15 3:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-15 2:35 [PATCH 0/2] Add CMDQ driver support for mt8188 Jason-JH.Lin 2023-12-15 2:35 ` [PATCH 1/2] mailbox: mtk-cmdq: Sort cmdq platform data by compatible name Jason-JH.Lin 2023-12-15 2:47 ` CK Hu (胡俊光) 2023-12-15 2:35 ` [PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188 Jason-JH.Lin 2023-12-15 2:47 ` CK Hu (胡俊光) 2023-12-15 3:06 ` Jason-JH Lin (林睿祥)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox