* Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP [not found] <20140916023736.49db964e@as> @ 2014-09-19 11:21 ` James Hogan 2014-09-19 13:34 ` Aaron Tomlin 0 siblings, 1 reply; 2+ messages in thread From: James Hogan @ 2014-09-19 11:21 UTC (permalink / raw) To: Chuck Ebbert, Helge Deller Cc: linux-kernel, linux-parisc, Aaron Tomlin, linux-metag Hi Chuck, On 16/09/14 08:37, Chuck Ebbert wrote: > static inline unsigned long *end_of_stack(struct task_struct *p) > { > +#ifdef CONFIG_STACK_GROWSUP > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1; Nit: this line should probably be wrapped to 80 columns. Other than that, I've tested this on metag and can confirm that it fixes the following BUG which you would otherwise get during boot with Aaron's patches: BUG: failure at kernel/sched/core.c:2664/schedule_debug()! Kernel panic - not syncing: BUG! Tested-by: James Hogan <james.hogan@imgtec.com> [metag] Acked-by: James Hogan <james.hogan@imgtec.com> Aaron: please can you try to get this patch applied before your patch series. Thanks James ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP 2014-09-19 11:21 ` [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP James Hogan @ 2014-09-19 13:34 ` Aaron Tomlin 0 siblings, 0 replies; 2+ messages in thread From: Aaron Tomlin @ 2014-09-19 13:34 UTC (permalink / raw) To: mingo Cc: Chuck Ebbert, Helge Deller, linux-kernel, linux-parisc, linux-metag, James Hogan On Fri, Sep 19, 2014 at 12:21:37PM +0100, James Hogan wrote: > Hi Chuck, > > On 16/09/14 08:37, Chuck Ebbert wrote: > > static inline unsigned long *end_of_stack(struct task_struct *p) > > { > > +#ifdef CONFIG_STACK_GROWSUP > > + return (unsigned long *)((unsigned long)task_thread_info(p) + THREAD_SIZE) - 1; > > Nit: this line should probably be wrapped to 80 columns. > > Other than that, I've tested this on metag and can confirm that it fixes > the following BUG which you would otherwise get during boot with Aaron's > patches: > > BUG: failure at kernel/sched/core.c:2664/schedule_debug()! > Kernel panic - not syncing: BUG! > > Tested-by: James Hogan <james.hogan@imgtec.com> [metag] > Acked-by: James Hogan <james.hogan@imgtec.com> OK. Acked-by: Aaron Tomlin <atomlin@redhat.com> > Aaron: please can you try to get this patch applied before your patch > series. Ingo, I hope it's not too late to get this patch in (once the nit has been addressed) for CONFIG_STACK_GROWSUP? Regards, -- Aaron Tomlin ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-19 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140916023736.49db964e@as>
2014-09-19 11:21 ` [PATCH] Fix end_of_stack() fn and location of stack canary for archs using STACK_GROWSUP James Hogan
2014-09-19 13:34 ` Aaron Tomlin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox