From: "Kevin D. Kissell" <kevink@mips.com>
To: "Rojhalat Ibrahim" <imr@rtschenk.de>
Cc: "Mark E Mason" <mark.e.mason@broadcom.com>, <linux-mips@linux-mips.org>
Subject: Re: Tracking down exception in sched.c
Date: Mon, 20 Feb 2006 15:52:52 +0100 [thread overview]
Message-ID: <003c01c6362d$53ea4c90$10eca8c0@grendel> (raw)
In-Reply-To: 43F9D215.3090506@rtschenk.de
> The behavior of the two loops is not the same because sched_init
> is called long before smp_prepare_cpus. Therefore for_each_cpu
> only loops once for CPU 0. I know this is not a great fix.
> I simply reverted the code to what's worked before.
It's certainly the code that I'm still using! ;o) So prom_build_cpu_map
needs to be called earlier (as in maybe from smp_prepare_boot_cpu?).
Either that, or each secondary needs to take responsibility for initializing
its own run queue, but I find the thought of having the system up and
running SMP with some run queues not yet initialized makes me nervous.
Regards,
Kevin K.
WARNING: multiple messages have this Message-ID (diff)
From: "Kevin D. Kissell" <kevink@mips.com>
To: Rojhalat Ibrahim <imr@rtschenk.de>
Cc: Mark E Mason <mark.e.mason@broadcom.com>, linux-mips@linux-mips.org
Subject: Re: Tracking down exception in sched.c
Date: Mon, 20 Feb 2006 15:52:52 +0100 [thread overview]
Message-ID: <003c01c6362d$53ea4c90$10eca8c0@grendel> (raw)
Message-ID: <20060220145252.NpHaVDQPHXERPVYb6wYBY_3-4EUAuG4377fJH11dBJg@z> (raw)
In-Reply-To: 43F9D215.3090506@rtschenk.de
> The behavior of the two loops is not the same because sched_init
> is called long before smp_prepare_cpus. Therefore for_each_cpu
> only loops once for CPU 0. I know this is not a great fix.
> I simply reverted the code to what's worked before.
It's certainly the code that I'm still using! ;o) So prom_build_cpu_map
needs to be called earlier (as in maybe from smp_prepare_boot_cpu?).
Either that, or each secondary needs to take responsibility for initializing
its own run queue, but I find the thought of having the system up and
running SMP with some run queues not yet initialized makes me nervous.
Regards,
Kevin K.
next prev parent reply other threads:[~2006-02-20 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 23:18 Tracking down exception in sched.c Mark E Mason
2006-02-20 12:09 ` Rojhalat Ibrahim
2006-02-20 13:35 ` Kevin D. Kissell
2006-02-20 14:28 ` Rojhalat Ibrahim
2006-02-20 14:52 ` Kevin D. Kissell [this message]
2006-02-20 14:52 ` Kevin D. Kissell
2006-02-20 20:27 ` Kevin D. Kissell
2006-02-21 1:46 ` Ralf Baechle
2006-02-20 14:40 ` Kevin D. Kissell
2006-02-20 14:40 ` Kevin D. Kissell
2006-02-20 13:35 ` Ralf Baechle
2006-02-20 14:35 ` Kevin D. Kissell
2006-02-20 14:35 ` Kevin D. Kissell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003c01c6362d$53ea4c90$10eca8c0@grendel' \
--to=kevink@mips.com \
--cc=imr@rtschenk.de \
--cc=linux-mips@linux-mips.org \
--cc=mark.e.mason@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox