From: "Svetoslav Neykov" <svetoslav@neykov.name>
To: "'Marc Kleine-Budde'" <mkl@pengutronix.de>,
"'Alexander Shishkin'" <alexander.shishkin@linux.intel.com>
Cc: "'Ralf Baechle'" <ralf@linux-mips.org>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Gabor Juhos'" <juhosg@openwrt.org>,
"'John Crispin'" <blogic@openwrt.org>,
"'Alan Stern'" <stern@rowland.harvard.edu>,
"'Luis R. Rodriguez'" <mcgrof@qca.qualcomm.com>,
<linux-mips@linux-mips.org>, <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support
Date: Fri, 10 May 2013 00:22:41 +0300 [thread overview]
Message-ID: <013d01ce4cfb$5830ab90$089202b0$@neykov.name> (raw)
In-Reply-To: <5154508B.6050509@pengutronix.de>
Hi Marc,
Marc Kleine-Budde [mailto:mkl@pengutronix.de] (On Thursday, March 28, 2013
4:16 PM)
>On 03/28/2013 10:28 AM, Alexander Shishkin wrote:
>> Svetoslav Neykov <svetoslav@neykov.name> writes:
>>
>>> Convert between big-endian and little-endian format when accessing
>>> the usb controller structures which are little-endian by
>>> specification. Fix cases where the little-endian memory layout is
>>> taken for granted. The patch doesn't have any effect on the already
>>> supported little-endian architectures.
>
>Has anyone tested how the cpu_to_le32 and vice versa effects the
>load/store operations? Does the compiler generate full 32 bit accesses
>on mips (and big endian arm) or is a byte-shift-or pattern used?
Better late than never... I have checked your question, the value is loaded
in a register and then swapped, so the read is performed only once.
Regards,
Svetoslav.
WARNING: multiple messages have this Message-ID (diff)
From: "Svetoslav Neykov" <svetoslav@neykov.name>
To: 'Marc Kleine-Budde' <mkl@pengutronix.de>,
'Alexander Shishkin' <alexander.shishkin@linux.intel.com>
Cc: 'Ralf Baechle' <ralf@linux-mips.org>,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
'Gabor Juhos' <juhosg@openwrt.org>,
'John Crispin' <blogic@openwrt.org>,
'Alan Stern' <stern@rowland.harvard.edu>,
"'Luis R. Rodriguez'" <mcgrof@qca.qualcomm.com>,
linux-mips@linux-mips.org, linux-usb@vger.kernel.org
Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support
Date: Fri, 10 May 2013 00:22:41 +0300 [thread overview]
Message-ID: <013d01ce4cfb$5830ab90$089202b0$@neykov.name> (raw)
Message-ID: <20130509212241.BAIImTpC2BS-TG7tEDVlQRao2wmVvfGOuQWhMGoapn4@z> (raw)
In-Reply-To: <5154508B.6050509@pengutronix.de>
Hi Marc,
Marc Kleine-Budde [mailto:mkl@pengutronix.de] (On Thursday, March 28, 2013
4:16 PM)
>On 03/28/2013 10:28 AM, Alexander Shishkin wrote:
>> Svetoslav Neykov <svetoslav@neykov.name> writes:
>>
>>> Convert between big-endian and little-endian format when accessing
>>> the usb controller structures which are little-endian by
>>> specification. Fix cases where the little-endian memory layout is
>>> taken for granted. The patch doesn't have any effect on the already
>>> supported little-endian architectures.
>
>Has anyone tested how the cpu_to_le32 and vice versa effects the
>load/store operations? Does the compiler generate full 32 bit accesses
>on mips (and big endian arm) or is a byte-shift-or pattern used?
Better late than never... I have checked your question, the value is loaded
in a register and then swapped, so the read is performed only once.
Regards,
Svetoslav.
next prev parent reply other threads:[~2013-05-09 21:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 22:17 [PATCH v2 0/2] Chipidea driver support for the AR933x platform Svetoslav Neykov
2013-03-01 22:17 ` [PATCH v2 1/2] usb: chipidea: big-endian support Svetoslav Neykov
2013-03-28 9:28 ` Alexander Shishkin
2013-03-28 9:28 ` Alexander Shishkin
2013-03-28 14:12 ` Michael Grzeschik
2013-03-28 16:06 ` Alexander Shishkin
2013-03-28 21:30 ` Svetoslav Neykov
2013-03-28 21:30 ` Svetoslav Neykov
2013-03-29 14:58 ` Alexander Shishkin
2013-03-28 14:15 ` Marc Kleine-Budde
2013-05-09 21:22 ` Svetoslav Neykov [this message]
2013-05-09 21:22 ` Svetoslav Neykov
2013-05-15 14:29 ` Marc Kleine-Budde
2013-03-28 22:25 ` Svetoslav Neykov
2013-03-28 22:25 ` Svetoslav Neykov
2013-03-29 15:09 ` Alexander Shishkin
2013-03-01 22:17 ` [PATCH v2 2/2] usb: chipidea: AR933x platform support for the chipidea driver Svetoslav Neykov
2013-03-28 12:01 ` Alexander Shishkin
2013-03-28 12:01 ` Alexander Shishkin
2013-03-28 22:23 ` Svetoslav Neykov
2013-03-28 22:23 ` Svetoslav Neykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013d01ce4cfb$5830ab90$089202b0$@neykov.name' \
--to=svetoslav@neykov.name \
--cc=alexander.shishkin@linux.intel.com \
--cc=blogic@openwrt.org \
--cc=gregkh@linuxfoundation.org \
--cc=juhosg@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=mkl@pengutronix.de \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox