From: "Kevin D. Kissell" <kevink@mips.com>
To: "Daniel Jacobowitz" <dan@debian.org>, "Jun Sun" <jsun@mvista.com>
Cc: "MIPS/Linux List \(SGI\)" <linux-mips@oss.sgi.com>
Subject: Re: FP emulator patch
Date: Fri, 17 Aug 2001 01:38:06 +0200 [thread overview]
Message-ID: <01fc01c126ac$866ceb40$0deca8c0@Ulysses> (raw)
In-Reply-To: 20010816153702.A21978@nevyn.them.org
> > if (current->used_math) { /* Using the FPU again.
*/
> > lazy_fpu_switch(last_task_used_math);
> > } else { /* First time FPU user.
*/
> > init_fpu();
> > current->used_math = 1;
> > }
> > last_task_used_math = current;
> >
...
> > BTW, do I see another bug here in do_cpu()? It seems that before we
call
> > init_fpu(), we should check last_task_used_math. If it is not NULL, we
should
> > save the FP state to the last_task_used_math. Hmm, strange ...
>
> I thought I got all of these... <sigh>
Looks like that should be:
} else {
if (last_task_used_math != NULL)
save_fp(last_task_used_math);
init_fpu()
current->used_math = 1;
}
And things will be OK. What's wierd is that I could have sworn
that I looked at this code long ago, and that there was a save
there. But even in the 2.2.12-based tree, there is none.
It's quite late here in France. If one (or more) of you guys could
sketch a code fragment that would copy FP context back and
forth between a thread structure and a sigcontext without passing
through the FPU while I'm sleeping, I'll put together an integrated
patch tomorrow.
Regards,
Kevin K.
WARNING: multiple messages have this Message-ID (diff)
From: "Kevin D. Kissell" <kevink@mips.com>
To: Daniel Jacobowitz <dan@debian.org>, Jun Sun <jsun@mvista.com>
Cc: "MIPS/Linux List (SGI)" <linux-mips@oss.sgi.com>
Subject: Re: FP emulator patch
Date: Fri, 17 Aug 2001 01:38:06 +0200 [thread overview]
Message-ID: <01fc01c126ac$866ceb40$0deca8c0@Ulysses> (raw)
Message-ID: <20010816233806.uNLRIivZoXIgq6Pl0v3-qJFNfQEl0Gf_Hr-fqTzY6qA@z> (raw)
In-Reply-To: 20010816153702.A21978@nevyn.them.org
> > if (current->used_math) { /* Using the FPU again.
*/
> > lazy_fpu_switch(last_task_used_math);
> > } else { /* First time FPU user.
*/
> > init_fpu();
> > current->used_math = 1;
> > }
> > last_task_used_math = current;
> >
...
> > BTW, do I see another bug here in do_cpu()? It seems that before we
call
> > init_fpu(), we should check last_task_used_math. If it is not NULL, we
should
> > save the FP state to the last_task_used_math. Hmm, strange ...
>
> I thought I got all of these... <sigh>
Looks like that should be:
} else {
if (last_task_used_math != NULL)
save_fp(last_task_used_math);
init_fpu()
current->used_math = 1;
}
And things will be OK. What's wierd is that I could have sworn
that I looked at this code long ago, and that there was a save
there. But even in the 2.2.12-based tree, there is none.
It's quite late here in France. If one (or more) of you guys could
sketch a code fragment that would copy FP context back and
forth between a thread structure and a sigcontext without passing
through the FPU while I'm sleeping, I'll put together an integrated
patch tomorrow.
Regards,
Kevin K.
next prev parent reply other threads:[~2001-08-16 23:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 18:23 FP emulator patch Kevin D. Kissell
2001-08-16 18:23 ` Kevin D. Kissell
2001-08-16 18:49 ` Pete Popov
2001-08-16 18:53 ` Daniel Jacobowitz
2001-08-16 19:15 ` Jun Sun
2001-08-16 20:40 ` Kevin D. Kissell
2001-08-16 20:40 ` Kevin D. Kissell
2001-08-16 21:34 ` Jun Sun
2001-08-16 22:33 ` Kevin D. Kissell
2001-08-16 22:33 ` Kevin D. Kissell
2001-08-16 22:38 ` Pete Popov
2001-08-16 22:37 ` Daniel Jacobowitz
2001-08-16 23:12 ` Jun Sun
2001-08-16 23:38 ` Kevin D. Kissell [this message]
2001-08-16 23:38 ` Kevin D. Kissell
2001-08-16 19:20 ` Kevin D. Kissell
2001-08-16 19:20 ` Kevin D. Kissell
2001-08-16 20:20 ` Jun Sun
-- strict thread matches above, loose matches on Subject: below --
2002-09-10 11:55 Carsten Langgaard
2001-08-16 22:58 Kevin D. Kissell
2001-08-16 22:58 ` Kevin D. Kissell
2001-08-16 23:14 ` Jun Sun
2001-08-16 23:46 ` Kevin D. Kissell
2001-08-16 23:46 ` Kevin D. Kissell
2001-08-15 12:53 Carsten Langgaard
2001-08-15 18:06 ` Daniel Jacobowitz
2001-08-16 0:05 ` Kevin D. Kissell
2001-08-16 0:05 ` Kevin D. Kissell
2001-08-16 4:20 ` Atsushi Nemoto
2001-08-16 12:35 ` Kevin D. Kissell
2001-08-16 12:35 ` Kevin D. Kissell
2001-08-16 7:07 ` Carsten Langgaard
2001-08-16 4:35 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01fc01c126ac$866ceb40$0deca8c0@Ulysses' \
--to=kevink@mips.com \
--cc=dan@debian.org \
--cc=jsun@mvista.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox