* Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
@ 2003-11-12 18:43 Jack Miller
2003-11-13 0:56 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Jack Miller @ 2003-11-12 18:43 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Linux-MIPS
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
Ralf,
Please apply this patch for the file drivers/ide/pci/alim15x3.c. It
fixes the LBA addressing mode for chip revisions <= 0xC4. Thank-You.
Regards,
Jack
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 408 bytes --]
--- alim15x3.c.orig 2003-11-12 10:32:04.000000000 -0800
+++ alim15x3.c 2003-11-12 08:18:08.000000000 -0800
@@ -760,7 +760,7 @@
hwif->speedproc = &ali15x3_tune_chipset;
/* Don't use LBA48 on ALi devices before rev 0xC5 */
- hwif->addressing = (m5229_revision <= 0xC4) ? 1 : 0;
+ hwif->addressing = (m5229_revision <= 0xC4) ? 0 : 1;
if (!hwif->dma_base) {
hwif->drives[0].autotune = 1;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
2003-11-12 18:43 Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3 Jack Miller
@ 2003-11-13 0:56 ` Alan Cox
2003-11-13 1:13 ` Jack Miller
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2003-11-13 0:56 UTC (permalink / raw)
To: Jack Miller; +Cc: Ralf Baechle, Linux-MIPS
On Mer, 2003-11-12 at 18:43, Jack Miller wrote:
> Ralf,
> Please apply this patch for the file drivers/ide/pci/alim15x3.c. It
> fixes the LBA addressing mode for chip revisions <= 0xC4. Thank-You.
It seems to break it not fix it.
addressing = 1 means no LBA48
addressing = 0 means LBA48
Alan
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
2003-11-13 0:56 ` Alan Cox
@ 2003-11-13 1:13 ` Jack Miller
2003-11-13 8:59 ` Jan-Benedict Glaw
2003-11-13 22:37 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: Jack Miller @ 2003-11-13 1:13 UTC (permalink / raw)
To: Alan Cox, Jack Miller; +Cc: Ralf Baechle, Linux-MIPS
Alan,
I am not so sure of that. If you look at ide-disk.c:__ide_do_rw_disk(),
there is a local variable assignment statement:
u8 lba48 = (drive->addressing = 1) ? 1 : 0;
So it would seem that the problem is elswhere ?
-Jack
> -----Original Message-----
> From: linux-mips-bounce@linux-mips.org
> [mailto:linux-mips-bounce@linux-mips.org]On Behalf Of Alan Cox
> Sent: Wednesday, November 12, 2003 4:57 PM
> To: Jack Miller
> Cc: Ralf Baechle; Linux-MIPS
> Subject: Re: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
>
>
> On Mer, 2003-11-12 at 18:43, Jack Miller wrote:
> > Ralf,
> > Please apply this patch for the file drivers/ide/pci/alim15x3.c. It
> > fixes the LBA addressing mode for chip revisions <= 0xC4. Thank-You.
>
> It seems to break it not fix it.
>
> addressing = 1 means no LBA48
> addressing = 0 means LBA48
>
> Alan
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
2003-11-13 1:13 ` Jack Miller
@ 2003-11-13 8:59 ` Jan-Benedict Glaw
2003-11-13 17:49 ` Jack Miller
2003-11-13 22:37 ` Alan Cox
1 sibling, 1 reply; 6+ messages in thread
From: Jan-Benedict Glaw @ 2003-11-13 8:59 UTC (permalink / raw)
To: Linux-MIPS
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Wed, 2003-11-12 17:13:53 -0800, Jack Miller <jack.miller@pioneer-pdt.com>
wrote in message <JCELLCFDJLFKPOBFKGFNEENFCHAA.jack.miller@pioneer-pdt.com>:
> Alan,
> I am not so sure of that. If you look at ide-disk.c:__ide_do_rw_disk(),
> there is a local variable assignment statement:
>
> u8 lba48 = (drive->addressing = 1) ? 1 : 0;
^^^
Explode. Now, lba48 would _always_ be 1.
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak!
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
2003-11-13 8:59 ` Jan-Benedict Glaw
@ 2003-11-13 17:49 ` Jack Miller
0 siblings, 0 replies; 6+ messages in thread
From: Jack Miller @ 2003-11-13 17:49 UTC (permalink / raw)
To: Jan-Benedict Glaw, Linux-MIPS
Sorry for the typo in the transcription, the source code is correct
regarding the test and assignment.
> -----Original Message-----
> From: linux-mips-bounce@linux-mips.org
> [mailto:linux-mips-bounce@linux-mips.org]On Behalf Of Jan-Benedict Glaw
> Sent: Thursday, November 13, 2003 12:59 AM
> To: Linux-MIPS
> Subject: Re: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
>
>
> On Wed, 2003-11-12 17:13:53 -0800, Jack Miller
> <jack.miller@pioneer-pdt.com>
> wrote in message
> <JCELLCFDJLFKPOBFKGFNEENFCHAA.jack.miller@pioneer-pdt.com>:
> > Alan,
> > I am not so sure of that. If you look at
> ide-disk.c:__ide_do_rw_disk(),
> > there is a local variable assignment statement:
> >
> > u8 lba48 = (drive->addressing = 1) ? 1 : 0;
> ^^^
>
> Explode. Now, lba48 would _always_ be 1.
>
> MfG, JBG
>
> --
> Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481
> "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur |
> Gegen Krieg
> fuer einen Freien Staat voll Freier Bürger" | im Internet! |
> im Irak!
> ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW |
> DRM | TCPA));
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3
2003-11-13 1:13 ` Jack Miller
2003-11-13 8:59 ` Jan-Benedict Glaw
@ 2003-11-13 22:37 ` Alan Cox
1 sibling, 0 replies; 6+ messages in thread
From: Alan Cox @ 2003-11-13 22:37 UTC (permalink / raw)
To: Jack Miller; +Cc: Jack Miller, Ralf Baechle, Linux-MIPS
On Iau, 2003-11-13 at 01:13, Jack Miller wrote:
> Alan,
> I am not so sure of that. If you look at ide-disk.c:__ide_do_rw_disk(),
> there is a local variable assignment statement:
>
> u8 lba48 = (drive->addressing = 1) ? 1 : 0;
>
> So it would seem that the problem is elswhere ?
drive and hwif->addressing are different. (Not my idea don't blame me!)
In the last code I did before going on sabattical its all become a bit
irrelevant as I implemented the notion of lba48 pio-only
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-11-13 22:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-12 18:43 Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3 Jack Miller
2003-11-13 0:56 ` Alan Cox
2003-11-13 1:13 ` Jack Miller
2003-11-13 8:59 ` Jan-Benedict Glaw
2003-11-13 17:49 ` Jack Miller
2003-11-13 22:37 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox