Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "ankur maheshwari" <ankur_maheshwari@procsys.com>
To: "Jean Delvare" <khali@linux-fr.org>,
	"Pete Popov" <ppopov@embeddedalley.com>
Cc: <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: Re: i2c-algo-ite and i2c-ite planned for removal
Date: Wed, 21 Jun 2006 11:08:34 +0530	[thread overview]
Message-ID: <110701c694f4$f1412fb0$f301a8c0@procsys> (raw)
In-Reply-To: 20060620120836.628ddc79.khali@linux-fr.org

hi all,

I have used once i2c-adap-ite and i2c-algo-ite for ite-8712 chip and it
worked fine for me in MV 2.4.25. Its been an year ago, I asked on same forum
if some one has used it before but I didn't got any reply.

I added this struct definition in a .h (i2c-adap-ite.h) file which we need
to include in i2c-adap-ite.c also program ite-8712 controller pins for i2c
use.

struct iic_ite {
	int iic_base;
	int iic_irq;
	int iic_clock;
	int iic_own;
};

It worked perfectly fine for me.

It's just an info on ite-chip works, to remove it from kernel tree .....
decision is up to you : ).

thanks,
Ankur

----- Original Message -----
From: "Jean Delvare" <khali@linux-fr.org>
To: "Pete Popov" <ppopov@embeddedalley.com>
Cc: <linux-mips@linux-mips.org>; <linux-kernel@vger.kernel.org>
Sent: Tuesday, June 20, 2006 3:38 PM
Subject: Re: i2c-algo-ite and i2c-ite planned for removal


> Hi Pete,
>
> > > > For historical correctness, this driver was once upon a time usable,
> > > > though it was a few years ago. It was written by MV for some ref
board
> > > > that had the ITE chip and it did work. That ref board is no longer
> > > > around so it's probably safe to nuke the driver.
> > >
> > > In which kernel version? In every version I checked (2.4.12, 2.4.30,
> > > 2.6.0 and 2.6.16) it wouldn't compile due to struct iic_ite being used
> > > but never defined (and possibly other errors, but I can't test-compile
> > > the driver.)
> >
> > Honestly, I don't remember. I think it was one of the very first 2.6
> > kernels because when MV first released a 2.6 product, 2.6 was still
> > 'experimental'. It's quite possible of course that the driver was never
> > properly merged upstream in the community tree(s). But I do know that it
> > worked in the internal MV tree and an effort was made to get the driver
> > accepted upstream.
>
> I couldn't find any evidence of this effort. Whatever, past is past, if
> someone fixes the i2c-ite and i2c-algo-ite drivers soon, fine with me,
> if not, the drivers will be deleted (which doesn't mean they can't be
> resurrected later if there is interest and someone takes over
> maintenance.) I'm setting the deadline to September 2006.
>
> --
> Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: "ankur maheshwari" <ankur_maheshwari@procsys.com>
To: Jean Delvare <khali@linux-fr.org>, Pete Popov <ppopov@embeddedalley.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: i2c-algo-ite and i2c-ite planned for removal
Date: Wed, 21 Jun 2006 11:08:34 +0530	[thread overview]
Message-ID: <110701c694f4$f1412fb0$f301a8c0@procsys> (raw)
Message-ID: <20060621053834.lw9hlJDS5FBu_gvN7u1kQTDAHRLzJ7xyKMBFdoVNquM@z> (raw)
In-Reply-To: 20060620120836.628ddc79.khali@linux-fr.org

hi all,

I have used once i2c-adap-ite and i2c-algo-ite for ite-8712 chip and it
worked fine for me in MV 2.4.25. Its been an year ago, I asked on same forum
if some one has used it before but I didn't got any reply.

I added this struct definition in a .h (i2c-adap-ite.h) file which we need
to include in i2c-adap-ite.c also program ite-8712 controller pins for i2c
use.

struct iic_ite {
	int iic_base;
	int iic_irq;
	int iic_clock;
	int iic_own;
};

It worked perfectly fine for me.

It's just an info on ite-chip works, to remove it from kernel tree .....
decision is up to you : ).

thanks,
Ankur

----- Original Message -----
From: "Jean Delvare" <khali@linux-fr.org>
To: "Pete Popov" <ppopov@embeddedalley.com>
Cc: <linux-mips@linux-mips.org>; <linux-kernel@vger.kernel.org>
Sent: Tuesday, June 20, 2006 3:38 PM
Subject: Re: i2c-algo-ite and i2c-ite planned for removal


> Hi Pete,
>
> > > > For historical correctness, this driver was once upon a time usable,
> > > > though it was a few years ago. It was written by MV for some ref
board
> > > > that had the ITE chip and it did work. That ref board is no longer
> > > > around so it's probably safe to nuke the driver.
> > >
> > > In which kernel version? In every version I checked (2.4.12, 2.4.30,
> > > 2.6.0 and 2.6.16) it wouldn't compile due to struct iic_ite being used
> > > but never defined (and possibly other errors, but I can't test-compile
> > > the driver.)
> >
> > Honestly, I don't remember. I think it was one of the very first 2.6
> > kernels because when MV first released a 2.6 product, 2.6 was still
> > 'experimental'. It's quite possible of course that the driver was never
> > properly merged upstream in the community tree(s). But I do know that it
> > worked in the internal MV tree and an effort was made to get the driver
> > accepted upstream.
>
> I couldn't find any evidence of this effort. Whatever, past is past, if
> someone fixes the i2c-ite and i2c-algo-ite drivers soon, fine with me,
> if not, the drivers will be deleted (which doesn't mean they can't be
> resurrected later if there is interest and someone takes over
> maintenance.) I'm setting the deadline to September 2006.
>
> --
> Jean Delvare

  reply	other threads:[~2006-06-21  5:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 20:57 i2c-algo-ite and i2c-ite planned for removal Jean Delvare
2006-06-15 21:23 ` Pete Popov
2006-06-16 20:29   ` Jean Delvare
2006-06-19 16:45     ` Pete Popov
2006-06-20 10:08       ` Jean Delvare
2006-06-21  5:38         ` ankur maheshwari [this message]
2006-06-21  5:38           ` ankur maheshwari
2006-06-22 11:22           ` Ralf Baechle
2006-06-22 10:59   ` Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2006-06-16 17:10 Shane McDonald
2006-06-16 18:20 ` Martin Michlmayr
2006-06-16 20:32 Raj Palani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='110701c694f4$f1412fb0$f301a8c0@procsys' \
    --to=ankur_maheshwari@procsys.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ppopov@embeddedalley.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox