Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: anemo@mba.ocn.ne.jp
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
	Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: [PATCH 6/7] Fix dump_stack()
Date: Tue,  1 Aug 2006 11:27:16 +0200	[thread overview]
Message-ID: <1154424439852-git-send-email-vagabon.xyz@gmail.com> (raw)
In-Reply-To: <11544244373398-git-send-email-vagabon.xyz@gmail.com>

When CONFIG_KALLSYMS is not set stack local is not initialized. Therefore
show_trace() won't display anything useful. This patch uses
prepare_frametrace() to setup the stack pointer before calling
show_trace().

Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
---
 arch/mips/kernel/traps.c |   13 +++----------
 1 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 15fa445..07191a6 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -203,17 +203,10 @@ void show_stack(struct task_struct *task
  */
 void dump_stack(void)
 {
-	unsigned long stack;
+	struct pt_regs regs;
 
-#ifdef CONFIG_KALLSYMS
-	if (!raw_show_trace) {
-		struct pt_regs regs;
-		prepare_frametrace(&regs);
-		show_backtrace(current, &regs);
-		return;
-	}
-#endif
-	show_trace(&stack);
+	prepare_frametrace(&regs);
+	show_backtrace(current, &regs);
 }
 
 EXPORT_SYMBOL(dump_stack);
-- 
1.4.2.rc2

  parent reply	other threads:[~2006-08-01  9:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01  9:27 [PATCH 0/7] Improve prologue analysis code Franck Bui-Huu
2006-08-01  9:27 ` [PATCH 1/7] Make get_frame_info() more readable Franck Bui-Huu
2006-08-01 15:02   ` Atsushi Nemoto
2006-08-01  9:27 ` [PATCH 2/7] Make get_frame_info() more robust Franck Bui-Huu
2006-08-01  9:27 ` [PATCH 3/7] Make frame_info_init() more readable Franck Bui-Huu
2006-08-01  9:27 ` [PATCH 4/7] Remove unused MODULE_RANGE macro Franck Bui-Huu
2006-08-01  9:27 ` [PATCH 5/7] Miscellaneous cleanup in prologue analysis code Franck Bui-Huu
2006-08-01  9:27 ` Franck Bui-Huu [this message]
2006-08-01 15:08   ` [PATCH 6/7] Fix dump_stack() Atsushi Nemoto
2006-08-01 15:36     ` Franck Bui-Huu
2006-08-01 16:05       ` Atsushi Nemoto
2006-08-01 17:43         ` Franck Bui-Huu
2006-08-02  1:54           ` Atsushi Nemoto
2006-08-01  9:27 ` [PATCH 7/7] Allow unwind_stack() to return ra for leaf function Franck Bui-Huu
2006-08-01 15:48   ` Atsushi Nemoto
2006-08-01 19:38     ` Franck Bui-Huu
2006-08-02  1:51       ` Atsushi Nemoto
2006-08-02 10:21         ` Franck Bui-Huu
2006-08-02 11:25           ` Atsushi Nemoto
2006-08-02 13:08             ` Franck Bui-Huu
2006-08-02 16:00               ` Atsushi Nemoto
2006-08-02 16:56                 ` Franck Bui-Huu
2006-08-03  4:52                   ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1154424439852-git-send-email-vagabon.xyz@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox