From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: vagabon.xyz@gmail.com, ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 6/7] Fix dump_stack()
Date: Tue, 01 Aug 2006 17:36:38 +0200 [thread overview]
Message-ID: <44CF7506.70106@innova-card.com> (raw)
In-Reply-To: <20060802.000837.37531064.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Tue, 1 Aug 2006 11:27:16 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
>> When CONFIG_KALLSYMS is not set stack local is not initialized. Therefore
>> show_trace() won't display anything useful. This patch uses
>> prepare_frametrace() to setup the stack pointer before calling
>> show_trace().
>
> It's not a bug. The original show_trace() needs an address on stack
> and dump_stack() surely give it by taking an address of local
> variable.
>
sorry, was drunk when writing the commit message...
> Eliminating the #ifdef itself looks good, but if you cleared contents
> of the "regs" before prepare_frametrace, you will get less false
> entries in the output.
>
well I don't see why...show_trace() is going to only use regs[29] which
is setup by prepare_frametrace()...
One other thing, why did you mark prepare_frametrace() as noinline ?
I would mark it as always_inline to get one less false entry in the
output.
Franck
next prev parent reply other threads:[~2006-08-01 15:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 9:27 [PATCH 0/7] Improve prologue analysis code Franck Bui-Huu
2006-08-01 9:27 ` [PATCH 1/7] Make get_frame_info() more readable Franck Bui-Huu
2006-08-01 15:02 ` Atsushi Nemoto
2006-08-01 9:27 ` [PATCH 2/7] Make get_frame_info() more robust Franck Bui-Huu
2006-08-01 9:27 ` [PATCH 3/7] Make frame_info_init() more readable Franck Bui-Huu
2006-08-01 9:27 ` [PATCH 4/7] Remove unused MODULE_RANGE macro Franck Bui-Huu
2006-08-01 9:27 ` [PATCH 5/7] Miscellaneous cleanup in prologue analysis code Franck Bui-Huu
2006-08-01 9:27 ` [PATCH 6/7] Fix dump_stack() Franck Bui-Huu
2006-08-01 15:08 ` Atsushi Nemoto
2006-08-01 15:36 ` Franck Bui-Huu [this message]
2006-08-01 16:05 ` Atsushi Nemoto
2006-08-01 17:43 ` Franck Bui-Huu
2006-08-02 1:54 ` Atsushi Nemoto
2006-08-01 9:27 ` [PATCH 7/7] Allow unwind_stack() to return ra for leaf function Franck Bui-Huu
2006-08-01 15:48 ` Atsushi Nemoto
2006-08-01 19:38 ` Franck Bui-Huu
2006-08-02 1:51 ` Atsushi Nemoto
2006-08-02 10:21 ` Franck Bui-Huu
2006-08-02 11:25 ` Atsushi Nemoto
2006-08-02 13:08 ` Franck Bui-Huu
2006-08-02 16:00 ` Atsushi Nemoto
2006-08-02 16:56 ` Franck Bui-Huu
2006-08-03 4:52 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CF7506.70106@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox