Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, Franck Bui-Huu <fbuihuu@gmail.com>
Subject: [PATCH 5/7] signal: test return value of install_sigtramp()
Date: Tue, 23 Jan 2007 15:18:21 +0100	[thread overview]
Message-ID: <1169561903723-git-send-email-fbuihuu@gmail.com> (raw)
In-Reply-To: <1169561903878-git-send-email-fbuihuu@gmail.com>

From: Franck Bui-Huu <fbuihuu@gmail.com>

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---
 arch/mips/kernel/signal.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/kernel/signal.c b/arch/mips/kernel/signal.c
index 468c74d..133ef74 100644
--- a/arch/mips/kernel/signal.c
+++ b/arch/mips/kernel/signal.c
@@ -187,7 +187,7 @@ int install_sigtramp(unsigned int __user *tramp, unsigned int syscall)
 	 */
 
 	err = __put_user(0x24020000 + syscall, tramp + 0);
-	err |= __put_user(0x0000000c          , tramp + 1);
+	err |= __put_user(0x0000000c         , tramp + 1);
 	if (ICACHE_REFILLS_WORKAROUND_WAR) {
 		err |= __put_user(0, tramp + 2);
 		err |= __put_user(0, tramp + 3);
@@ -403,7 +403,7 @@ int setup_frame(struct k_sigaction * ka, struct pt_regs *regs,
 	if (!access_ok(VERIFY_WRITE, frame, sizeof (*frame)))
 		goto give_sigsegv;
 
-	install_sigtramp(frame->sf_code, __NR_sigreturn);
+	err |= install_sigtramp(frame->sf_code, __NR_sigreturn);
 
 	err |= setup_sigcontext(regs, &frame->sf_sc);
 	err |= __copy_to_user(&frame->sf_mask, set, sizeof(*set));
@@ -450,7 +450,7 @@ int setup_rt_frame(struct k_sigaction * ka, struct pt_regs *regs,
 	if (!access_ok(VERIFY_WRITE, frame, sizeof (*frame)))
 		goto give_sigsegv;
 
-	install_sigtramp(frame->rs_code, __NR_rt_sigreturn);
+	err |= install_sigtramp(frame->rs_code, __NR_rt_sigreturn);
 
 	/* Create siginfo.  */
 	err |= copy_siginfo_to_user(&frame->rs_info, info);
-- 
1.4.4.3.ge6d4

  parent reply	other threads:[~2007-01-23 14:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-23 14:18 [PATCH 0/7] Clean up signal code Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 1/7] signals: reduce {setup,restore}_sigcontext sizes Franck Bui-Huu
2007-01-23 14:38   ` Ralf Baechle
2007-01-23 16:26     ` Franck Bui-Huu
2007-01-23 16:36       ` Ralf Baechle
2007-01-24 12:25     ` Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 2/7] signal: do not inline functions in signal-common.h Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 3/7] signal: clean up sigframe structure Franck Bui-Huu
2007-01-23 14:35   ` Ralf Baechle
2007-01-23 15:00     ` Franck Bui-Huu
2007-01-23 17:17       ` Ralf Baechle
2007-01-23 14:18 ` [PATCH 4/7] signal32: remove code duplication Franck Bui-Huu
2007-01-23 14:18 ` Franck Bui-Huu [this message]
2007-01-23 14:18 ` [PATCH 6/7] signal: factorize debug code Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 7/7] signal32: reduce {setup,restore}_sigcontext32 sizes Franck Bui-Huu
2007-01-23 14:32 ` [PATCH 0/7] Clean up signal code Ralf Baechle
2007-01-23 14:54   ` Franck Bui-Huu
2007-01-23 14:58   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169561903723-git-send-email-fbuihuu@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=fbuihuu@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox