From: Ralf Baechle <ralf@linux-mips.org>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 0/7] Clean up signal code
Date: Tue, 23 Jan 2007 14:32:14 +0000 [thread overview]
Message-ID: <20070123143214.GC18083@linux-mips.org> (raw)
In-Reply-To: <1169561903878-git-send-email-fbuihuu@gmail.com>
On Tue, Jan 23, 2007 at 03:18:16PM +0100, Franck Bui-Huu wrote:
> This patchset cleans up signal related code by factorizing code
> shared by all signal sources. The consequence is that the signal
> code is decreased a lot.
>
> This patchset has been splitted out into 7 differents patches
> to ease code review.
>
> Two questions are still open:
>
> (a) It seems that the status register is not saved by
> setup_sigcontext() and therefore not restored by
> restore_sigcontext(). Is it a bug ?
No. All the information in the MIPS c0_status register is priviledged.
Unlike CISC architectures MIPS has no flags such as zero, equal, overflow
or similar in the status register that is nothing that would constitute
part of the thread context.
The one flag one could possibly argument about might be c0_status.fr - but
none of the ABIs or tools or application software can make use of it ...
> (b) Status register is saved by setup_sigcontext32() but
> not restored by restore_sigcontext(). Is it a bug ?
Not really a bug but useless code, yes. We used to save c0_status in the
dark ages but again, no known code - not even IRIX code - relies on this
field.
> Unfortunately I do not have any 64 bits cross compiler setup
> and no adequate plateforms to test the changes introduced by
> this patchset in signal32.c and signal_n32.c. If someone
> could give it a try, that would be nice.
Will try to find some time but likely it'll take me well over a week so
maybe somebody else?
Ralf
next prev parent reply other threads:[~2007-01-23 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 14:18 [PATCH 0/7] Clean up signal code Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 1/7] signals: reduce {setup,restore}_sigcontext sizes Franck Bui-Huu
2007-01-23 14:38 ` Ralf Baechle
2007-01-23 16:26 ` Franck Bui-Huu
2007-01-23 16:36 ` Ralf Baechle
2007-01-24 12:25 ` Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 2/7] signal: do not inline functions in signal-common.h Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 3/7] signal: clean up sigframe structure Franck Bui-Huu
2007-01-23 14:35 ` Ralf Baechle
2007-01-23 15:00 ` Franck Bui-Huu
2007-01-23 17:17 ` Ralf Baechle
2007-01-23 14:18 ` [PATCH 4/7] signal32: remove code duplication Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 5/7] signal: test return value of install_sigtramp() Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 6/7] signal: factorize debug code Franck Bui-Huu
2007-01-23 14:18 ` [PATCH 7/7] signal32: reduce {setup,restore}_sigcontext32 sizes Franck Bui-Huu
2007-01-23 14:32 ` Ralf Baechle [this message]
2007-01-23 14:54 ` [PATCH 0/7] Clean up signal code Franck Bui-Huu
2007-01-23 14:58 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123143214.GC18083@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox