Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp,
	Franck Bui-Huu <fbuihuu@gmail.com>
Subject: [PATCH 1/3] signal: avoid useless test in do_signal()
Date: Fri,  9 Feb 2007 16:07:36 +0100	[thread overview]
Message-ID: <11710336594091-git-send-email-fbuihuu@gmail.com> (raw)
In-Reply-To: <1171033658561-git-send-email-fbuihuu@gmail.com>

From: Franck Bui-Huu <fbuihuu@gmail.com>

Indeed we can simply clear the flag whatever its value

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---
 arch/mips/kernel/signal.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/mips/kernel/signal.c b/arch/mips/kernel/signal.c
index 8dfb7b1..464d34b 100644
--- a/arch/mips/kernel/signal.c
+++ b/arch/mips/kernel/signal.c
@@ -552,10 +552,8 @@ void do_signal(struct pt_regs *regs)
 			 * and will be restored by sigreturn, so we can simply
 			 * clear the TIF_RESTORE_SIGMASK flag.
 			 */
-			if (test_thread_flag(TIF_RESTORE_SIGMASK))
-				clear_thread_flag(TIF_RESTORE_SIGMASK);
+			clear_thread_flag(TIF_RESTORE_SIGMASK);
 		}
-
 		return;
 	}
 
-- 
1.4.4.3.ge6d4

  reply	other threads:[~2007-02-09 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 15:07 [PATCH 0/3] More signal clean up Franck Bui-Huu
2007-02-09 15:07 ` Franck Bui-Huu [this message]
2007-02-09 16:21   ` [PATCH 1/3] signal: avoid useless test in do_signal() Ralf Baechle
2007-02-09 16:50     ` Franck Bui-Huu
2007-02-09 15:07 ` [PATCH 2/3] signals: make common _BLOCKABLE macro Franck Bui-Huu
2007-02-13  1:39   ` Ralf Baechle
2007-02-09 15:07 ` [PATCH 3/3] signal.c: fix gcc warning on 32 bits kernel Franck Bui-Huu
2007-02-09 16:18   ` Atsushi Nemoto
2007-02-09 16:34     ` Franck Bui-Huu
2007-02-09 21:00       ` Ralf Baechle
2007-02-12  9:01         ` Franck Bui-Huu
2007-02-12 14:04           ` Ralf Baechle
2007-02-12 15:25             ` Atsushi Nemoto
2007-02-13  1:43               ` Ralf Baechle
2007-02-13  2:05                 ` Ralf Baechle
2007-02-13 17:17                   ` Franck Bui-Huu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11710336594091-git-send-email-fbuihuu@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=fbuihuu@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox