From: Ralf Baechle <ralf@linux-mips.org>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp,
Franck Bui-Huu <fbuihuu@gmail.com>
Subject: Re: [PATCH 1/3] signal: avoid useless test in do_signal()
Date: Fri, 9 Feb 2007 16:21:18 +0000 [thread overview]
Message-ID: <20070209162118.GA26617@linux-mips.org> (raw)
In-Reply-To: <11710336594091-git-send-email-fbuihuu@gmail.com>
On Fri, Feb 09, 2007 at 04:07:36PM +0100, Franck Bui-Huu wrote:
> - if (test_thread_flag(TIF_RESTORE_SIGMASK))
> - clear_thread_flag(TIF_RESTORE_SIGMASK);
This is a microoptimization. The assumption here is TIF_RESTORE_SIGMASK
will rarely need to be cleared and atomic operations are somewhat
expensive if as in this case we have to assume the cacheline isn't
held exclusive yet.
Ralf
next prev parent reply other threads:[~2007-02-09 16:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 15:07 [PATCH 0/3] More signal clean up Franck Bui-Huu
2007-02-09 15:07 ` [PATCH 1/3] signal: avoid useless test in do_signal() Franck Bui-Huu
2007-02-09 16:21 ` Ralf Baechle [this message]
2007-02-09 16:50 ` Franck Bui-Huu
2007-02-09 15:07 ` [PATCH 2/3] signals: make common _BLOCKABLE macro Franck Bui-Huu
2007-02-13 1:39 ` Ralf Baechle
2007-02-09 15:07 ` [PATCH 3/3] signal.c: fix gcc warning on 32 bits kernel Franck Bui-Huu
2007-02-09 16:18 ` Atsushi Nemoto
2007-02-09 16:34 ` Franck Bui-Huu
2007-02-09 21:00 ` Ralf Baechle
2007-02-12 9:01 ` Franck Bui-Huu
2007-02-12 14:04 ` Ralf Baechle
2007-02-12 15:25 ` Atsushi Nemoto
2007-02-13 1:43 ` Ralf Baechle
2007-02-13 2:05 ` Ralf Baechle
2007-02-13 17:17 ` Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209162118.GA26617@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=fbuihuu@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox