From: Richard Purdie <rpurdie@rpsys.net>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH][2/6] led: add Cobalt Raq series LEDs support
Date: Thu, 20 Sep 2007 23:51:10 +0100 [thread overview]
Message-ID: <1190328670.5658.77.camel@localhost.localdomain> (raw)
In-Reply-To: <20070920230322.6600dd83.yoichi_yuasa@tripeaks.co.jp>
On Thu, 2007-09-20 at 23:03 +0900, Yoichi Yuasa wrote:
> Add Cobalt Raq series LEDs support.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
[...]
> diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/leds/leds-cobalt-raq.c mips/drivers/leds/leds-cobalt-raq.c
> --- mips-orig/drivers/leds/leds-cobalt-raq.c 1970-01-01 09:00:00.000000000 +0900
> +++ mips/drivers/leds/leds-cobalt-raq.c 2007-09-14 13:06:03.900173500 +0900
> @@ -0,0 +1,135 @@
[...]
> +static void __iomem *led_port;
> +static u8 led_value;
> +static DEFINE_SPINLOCK(led_value_lock);
> +
> +static void raq_web_led_set(struct led_classdev *led_cdev,
> + enum led_brightness brightness)
> +{
> + spin_lock_irq(&led_value_lock);
> +
> + if (brightness)
> + led_value |= LED_WEB;
> + else
> + led_value &= ~LED_WEB;
> + writeb(led_value, led_port);
> +
> + spin_unlock_irq(&led_value_lock);
> +}
You can't use the spin lock like that since the set function can get
called in interrupt context, you need to use irqsave/irqrestore
versions. I've already said this once...
Richard
next prev parent reply other threads:[~2007-09-20 22:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 14:02 [PATCH][1/6] led: rename leds-cobalt Yoichi Yuasa
2007-09-20 14:03 ` [PATCH][2/6] led: add Cobalt Raq series LEDs support Yoichi Yuasa
2007-09-20 14:05 ` [PATCH][3/6]led: add Cobalt Raq LEDs platform register Yoichi Yuasa
2007-09-20 14:06 ` [PATCH][4/6] led: update Cobalt Qube series front LED support Yoichi Yuasa
2007-09-20 14:08 ` [PATCH][5/6] led: add Cobalt Qube series front LED support to platform register Yoichi Yuasa
2007-09-20 14:10 ` [PATCH][6/6] led: add LED support to cobalt_defconfig Yoichi Yuasa
2007-09-20 16:41 ` Ralf Baechle
2007-09-20 16:40 ` [PATCH][5/6] led: add Cobalt Qube series front LED support to platform register Ralf Baechle
2007-09-20 16:38 ` [PATCH][4/6] led: update Cobalt Qube series front LED support Ralf Baechle
2007-09-20 16:31 ` [PATCH][3/6]led: add Cobalt Raq LEDs platform register Ralf Baechle
2007-09-20 16:00 ` [PATCH][2/6] led: add Cobalt Raq series LEDs support Ralf Baechle
2007-09-21 2:29 ` Yoichi Yuasa
2007-09-20 22:51 ` Richard Purdie [this message]
2007-09-20 14:17 ` [PATCH][1/6] led: rename leds-cobalt Florian Fainelli
2007-09-20 23:05 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190328670.5658.77.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox