From: Ralf Baechle <ralf@linux-mips.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: Richard Purdie <rpurdie@rpsys.net>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH][5/6] led: add Cobalt Qube series front LED support to platform register
Date: Thu, 20 Sep 2007 17:40:20 +0100 [thread overview]
Message-ID: <20070920164020.GF5522@linux-mips.org> (raw)
In-Reply-To: <20070920230841.5e4b0a05.yoichi_yuasa@tripeaks.co.jp>
On Thu, Sep 20, 2007 at 11:08:41PM +0900, Yoichi Yuasa wrote:
> Add Cobalt Qube series front LED support to platform register.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/cobalt/led.c mips/arch/mips/cobalt/led.c
> --- mips-orig/arch/mips/cobalt/led.c 2007-09-12 13:48:40.740621250 +0900
> +++ mips/arch/mips/cobalt/led.c 2007-09-12 13:47:59.474042250 +0900
> @@ -22,6 +22,8 @@
> #include <linux/ioport.h>
> #include <linux/platform_device.h>
>
> +#include <cobalt.h>
> +
> static struct resource cobalt_led_resource __initdata = {
> .start = 0x1c000000,
> .end = 0x1c000000,
> @@ -33,7 +35,11 @@ static __init int cobalt_led_add(void)
> struct platform_device *pdev;
> int retval;
>
> - pdev = platform_device_alloc("Cobalt Raq LEDs", -1);
> + if (cobalt_board_id == COBALT_BRD_ID_QUBE1 ||
> + cobalt_board_id == COBALT_BRD_ID_QUBE2)
> + pdev = platform_device_alloc("Cobalt Qube LEDs", -1);
> + else
> + pdev = platform_device_alloc("Cobalt Raq LEDs", -1);
Same thing - can you make that string something all lowercase without
spaces?
>
> if (!pdev)
> return -ENOMEM;
Ralf
next prev parent reply other threads:[~2007-09-20 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 14:02 [PATCH][1/6] led: rename leds-cobalt Yoichi Yuasa
2007-09-20 14:03 ` [PATCH][2/6] led: add Cobalt Raq series LEDs support Yoichi Yuasa
2007-09-20 14:05 ` [PATCH][3/6]led: add Cobalt Raq LEDs platform register Yoichi Yuasa
2007-09-20 14:06 ` [PATCH][4/6] led: update Cobalt Qube series front LED support Yoichi Yuasa
2007-09-20 14:08 ` [PATCH][5/6] led: add Cobalt Qube series front LED support to platform register Yoichi Yuasa
2007-09-20 14:10 ` [PATCH][6/6] led: add LED support to cobalt_defconfig Yoichi Yuasa
2007-09-20 16:41 ` Ralf Baechle
2007-09-20 16:40 ` Ralf Baechle [this message]
2007-09-20 16:38 ` [PATCH][4/6] led: update Cobalt Qube series front LED support Ralf Baechle
2007-09-20 16:31 ` [PATCH][3/6]led: add Cobalt Raq LEDs platform register Ralf Baechle
2007-09-20 16:00 ` [PATCH][2/6] led: add Cobalt Raq series LEDs support Ralf Baechle
2007-09-21 2:29 ` Yoichi Yuasa
2007-09-20 22:51 ` Richard Purdie
2007-09-20 14:17 ` [PATCH][1/6] led: rename leds-cobalt Florian Fainelli
2007-09-20 23:05 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920164020.GF5522@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=rpurdie@rpsys.net \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox