From: Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org>
To: mips kernel list <linux-mips@linux-mips.org>
Subject: Re: Preliminary patch for ip32 ttyS* device
Date: Wed, 31 Oct 2007 15:59:26 +0100 [thread overview]
Message-ID: <1193842766.16429.7.camel@scarafaggio> (raw)
In-Reply-To: <20071031130828.GE14187@linux-mips.org>
Il giorno mer, 31/10/2007 alle 13.08 +0000, Ralf Baechle ha scritto:
> On Tue, Oct 30, 2007 at 09:40:15PM +0100, Giuseppe Sacco wrote:
[...]
> > diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
> > index 3bb5d24..7caa877 100644
> > --- a/drivers/serial/serial_core.c
> > +++ b/drivers/serial/serial_core.c
> > @@ -2455,6 +2455,8 @@ int uart_match_port(struct uart_port *port1, struct uart_port *port2)
> > case UPIO_AU:
> > case UPIO_TSI:
> > case UPIO_DWAPB:
> > + if (port1->mapbase==0 && port2->mapbase==0)
> > + return (port1->membase == port2->membase);
>
> This hack is only needed because ->mapbase is not initialized.
Right, for a few days I tried to correctly initialise mapbase and
setting UPF_IOREMAP in order to let this code calculate membase:
up->port.membase = ioremap(up->port.mapbase, size);
(drivers/serial/8250.c, function serial8250_request_std_resource)
but maybe we can just leave mapbase == 0 and change uart_match_port() as
in my patch.
Any other option?
next prev parent reply other threads:[~2007-10-31 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 20:40 Preliminary patch for ip32 ttyS* device Giuseppe Sacco
2007-10-31 13:08 ` Ralf Baechle
2007-10-31 14:59 ` Giuseppe Sacco [this message]
2007-11-07 14:43 ` Giuseppe Sacco
2007-11-07 17:21 ` Maciej W. Rozycki
2007-11-17 19:35 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193842766.16429.7.camel@scarafaggio \
--to=giuseppe@eppesuigoccas.homedns.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox