From: Martin Michlmayr <tbm@cyrius.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org>,
mips kernel list <linux-mips@linux-mips.org>
Subject: Re: Preliminary patch for ip32 ttyS* device
Date: Sat, 17 Nov 2007 20:35:29 +0100 [thread overview]
Message-ID: <20071117193529.GA11798@deprecation.cyrius.com> (raw)
In-Reply-To: <Pine.LNX.4.64N.0711071716470.14970@blysk.ds.pg.gda.pl>
* Maciej W. Rozycki <macro@linux-mips.org> [2007-11-07 17:21]:
> > If mapbase isn't mandatory, the second part of my patch is
> > probably right and fixes a bug.
>
> You ought to use mapbase and ioremap() with new code as you are not
> allowed to use readb()/writeb()/etc. on addresses obtained otherwise
> than by calling ioremap(). The use of request_mem_region(), etc. is
> not strictly mandatory, but it is nice to have. Many serial drivers
> use these functions, so I cannot see a reason why it would be a
> hassle for ip32.
Can someone propose a patch? It's quote unfortuntely that serial on
IP32 is still broken (including 2.6.23).
--
Martin Michlmayr
http://www.cyrius.com/
prev parent reply other threads:[~2007-11-17 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 20:40 Preliminary patch for ip32 ttyS* device Giuseppe Sacco
2007-10-31 13:08 ` Ralf Baechle
2007-10-31 14:59 ` Giuseppe Sacco
2007-11-07 14:43 ` Giuseppe Sacco
2007-11-07 17:21 ` Maciej W. Rozycki
2007-11-17 19:35 ` Martin Michlmayr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117193529.GA11798@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=giuseppe@eppesuigoccas.homedns.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox