From: yanh <yanh@lemote.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>,
linux-mips@linux-mips.org, Arnaud Patard <apatard@mandriva.com>,
loongson-dev@googlegroups.com, zhangfx@lemote.com,
Philippe Vachon <philippe@cowpig.ca>,
Zhang Le <r0bertz@gentoo.org>, Erwan Lerale <erwan@thiscow.com>
Subject: Re: [PATCH 26/30] loongson: flush irq write operation
Date: Wed, 20 May 2009 15:58:04 +0800 [thread overview]
Message-ID: <1242806284.4382.72.camel@localhost.localdomain> (raw)
In-Reply-To: <20090520070719.GA24231@linux-mips.org>
在 2009-05-20三的 08:07 +0100,Ralf Baechle写道:
> On Wed, May 20, 2009 at 10:28:14AM +0800, yanh wrote:
>
> > I have test this patch just now. It works well on yeeloong.
>
> Thanks for testing.
>
> > I have one question what's the difference between the two patch?
>
> Uncached writes can't be re-ordered. By adding a read after the last
> write my patch forces not only completion of the preceding write but due
> to this ordering constraint also completion of all preceding writes is
> enforced.
>
> I/O space writes are slow. I mean slower than slugs in space. So my
> patch is an optimization but that was not the point; I really only meant
> to verify that we understood what's going on and we seem to. Now let's
> fix the real issue and make outX() non-posted.
Thanks for your explanation.
>
> Ralf
>
prev parent reply other threads:[~2009-05-20 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 22:28 [PATCH 26/30] loongson: flush irq write operation Wu Zhangjin
2009-05-15 22:28 ` Wu Zhangjin
2009-05-18 16:36 ` Ralf Baechle
2009-05-19 2:37 ` yanh
2009-05-19 16:01 ` Ralf Baechle
2009-05-20 2:28 ` yanh
2009-05-20 3:07 ` yanh
2009-05-20 7:07 ` Ralf Baechle
2009-05-20 7:58 ` yanh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242806284.4382.72.camel@localhost.localdomain \
--to=yanh@lemote.com \
--cc=apatard@mandriva.com \
--cc=erwan@thiscow.com \
--cc=linux-mips@linux-mips.org \
--cc=loongson-dev@googlegroups.com \
--cc=philippe@cowpig.ca \
--cc=r0bertz@gentoo.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox