From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Ralf Baechle <ralf@linux-mips.org>,
Wu Zhangjin <wuzhangjin@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@linux-mips.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kumar Gala <galak@gate.crashing.org>,
Becky Bruce <beckyb@kernel.crashing.org>,
Takashi Iwai <tiwai@suse.de>
Subject: [PATCH 4/5] ALSA: pcm - fix page conversion on non-coherent PPC arch
Date: Thu, 26 Nov 2009 16:13:07 +0100 [thread overview]
Message-ID: <1259248388-20095-5-git-send-email-tiwai@suse.de> (raw)
In-Reply-To: <1259248388-20095-4-git-send-email-tiwai@suse.de>
The non-cohernet PPC arch doesn't give the correct address by a simple
virt_to_page() for pages allocated via dma_alloc_coherent().
This patch adds a hack to fix the conversion similarly like MIPS.
Note that this doesn't fix perfectly: the pages should be marked with
proper pgprot value. This will be done in a future implementation like
the conversion to dma_mmap_coherent().
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/core/pcm_native.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index e48c5f6..76eb763 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3070,6 +3070,16 @@ snd_pcm_default_page_ops(struct snd_pcm_substream *substream, unsigned long ofs)
if (substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV)
return virt_to_page(CAC_ADDR(vaddr));
#endif
+#if defined(CONFIG_PPC32) && defined(CONFIG_NOT_COHERENT_CACHE)
+ if (substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV) {
+ dma_addr_t addr = substream->runtime->dma_addr + ofs;
+ addr -= get_dma_offset(substream->dma_buffer.dev.dev);
+ /* assume dma_handle set via pfn_to_phys() in
+ * mm/dma-noncoherent.c
+ */
+ return pfn_to_page(dma_handle >> PAGE_SHIFT);
+ }
+#endif
return virt_to_page(vaddr);
}
--
1.6.5.3
next prev parent reply other threads:[~2009-11-26 15:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 15:13 [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures Takashi Iwai
2009-11-26 15:13 ` [PATCH 1/5] ALSA: pcm - Use dma_mmap_coherent() if available Takashi Iwai
2009-11-26 15:13 ` [PATCH 2/5] ALSA: pcm - define snd_pcm_default_page_ops() Takashi Iwai
2009-11-26 15:13 ` [PATCH 3/5] ALSA: pcm - fix page conversion on non-coherent MIPS arch Takashi Iwai
2009-11-26 15:13 ` Takashi Iwai [this message]
2009-11-26 15:13 ` [PATCH 5/5] ALSA: Remove old DMA-mmap code from arm/devdma.c Takashi Iwai
2009-11-26 16:56 ` [PATCH 4/5] ALSA: pcm - fix page conversion on non-coherent PPC arch Takashi Iwai
2009-11-26 21:14 ` Benjamin Herrenschmidt
2009-11-26 20:51 ` Benjamin Herrenschmidt
2009-11-27 9:18 ` Takashi Iwai
2009-11-27 3:52 ` [PATCH 3/5] ALSA: pcm - fix page conversion on non-coherent MIPS arch Wu Zhangjin
2009-11-27 9:26 ` Takashi Iwai
2009-11-27 8:46 ` Ralf Baechle
2009-11-27 9:20 ` Takashi Iwai
2010-01-01 19:31 ` [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures Andreas Mohr
2010-01-12 7:02 ` Takashi Iwai
2010-01-13 9:07 ` Takashi Iwai
2010-01-14 7:46 ` Andreas Mohr
2010-01-14 7:54 ` Takashi Iwai
2010-01-15 3:28 ` Benjamin Herrenschmidt
2010-01-15 6:43 ` Takashi Iwai
2010-01-15 6:50 ` Benjamin Herrenschmidt
2010-01-15 7:32 ` Takashi Iwai
2010-01-13 9:28 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259248388-20095-5-git-send-email-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=beckyb@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=galak@gate.crashing.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox