Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH -queue v3] MIPS: Cleanup the debugging of compressed  kernel support
Date: Wed, 27 Jan 2010 02:06:48 +0800	[thread overview]
Message-ID: <1264529208.11605.3.camel@falcon> (raw)
In-Reply-To: <f861ec6f1001261007k4f71244fqcc92e2b6b1c9234c@mail.gmail.com>

On Tue, 2010-01-26 at 19:07 +0100, Manuel Lauss wrote:
> Hi!
> 
> On Tue, Jan 26, 2010 at 6:01 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > From: Wu Zhangjin <wuzhangjin@gmail.com>
> >
> > --- a/arch/mips/boot/compressed/Makefile
> > +++ b/arch/mips/boot/compressed/Makefile
> > @@ -32,7 +32,9 @@ KBUILD_AFLAGS := $(LINUXINCLUDE) $(KBUILD_AFLAGS) -D__ASSEMBLY__ \
> >
> >  obj-y := $(obj)/head.o $(obj)/decompress.o $(obj)/dbg.o
> >
> > +ifdef DEBUG_ZBOOT
> 
> The above doesn't work in my testing, but this does:
> ifeq ($(CONFIG_DEBUG_ZBOOT),y)

oh, my god, I have forgotten the prefix CONFIG_, perhaps Ralf will help to fix it ;)

it should be:

ifdef CONFIG_DEBUG_ZBOOT
...
endif

of course, your ifeq version also works ;)

Thanks & Regards!
	Wu Zhangjin

WARNING: multiple messages have this Message-ID (diff)
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH -queue v3] MIPS: Cleanup the debugging of compressed kernel support
Date: Wed, 27 Jan 2010 02:06:48 +0800	[thread overview]
Message-ID: <1264529208.11605.3.camel@falcon> (raw)
Message-ID: <20100126180648.3AOrlC1byr-FmXrs4OqiE3KpcPRVceVeAKd9wTJv1sA@z> (raw)
In-Reply-To: <f861ec6f1001261007k4f71244fqcc92e2b6b1c9234c@mail.gmail.com>

On Tue, 2010-01-26 at 19:07 +0100, Manuel Lauss wrote:
> Hi!
> 
> On Tue, Jan 26, 2010 at 6:01 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > From: Wu Zhangjin <wuzhangjin@gmail.com>
> >
> > --- a/arch/mips/boot/compressed/Makefile
> > +++ b/arch/mips/boot/compressed/Makefile
> > @@ -32,7 +32,9 @@ KBUILD_AFLAGS := $(LINUXINCLUDE) $(KBUILD_AFLAGS) -D__ASSEMBLY__ \
> >
> >  obj-y := $(obj)/head.o $(obj)/decompress.o $(obj)/dbg.o
> >
> > +ifdef DEBUG_ZBOOT
> 
> The above doesn't work in my testing, but this does:
> ifeq ($(CONFIG_DEBUG_ZBOOT),y)

oh, my god, I have forgotten the prefix CONFIG_, perhaps Ralf will help to fix it ;)

it should be:

ifdef CONFIG_DEBUG_ZBOOT
...
endif

of course, your ifeq version also works ;)

Thanks & Regards!
	Wu Zhangjin

  reply	other threads:[~2010-01-26 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 17:01 [PATCH -queue v3] MIPS: Cleanup the debugging of compressed kernel support Wu Zhangjin
2010-01-26 18:07 ` Manuel Lauss
2010-01-26 18:06   ` Wu Zhangjin [this message]
2010-01-26 18:06     ` Wu Zhangjin
2010-01-26 18:07   ` Manuel Lauss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264529208.11605.3.camel@falcon \
    --to=wuzhangjin@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=manuel.lauss@googlemail.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox