From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Alexander Clouter <alex@digriz.org.uk>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] MIPS: AR7 whitespace hacking
Date: Mon, 01 Feb 2010 14:29:17 +0800 [thread overview]
Message-ID: <1265005758.31984.8.camel@falcon> (raw)
In-Reply-To: <bq2h37-ch6.ln1@chipmunk.wormnet.eu>
On Sun, 2010-01-31 at 19:38 +0000, Alexander Clouter wrote:
> MIPS: AR7 whitespace hacking
>
> Signed-off-by: Alexander Clouter <alex@digriz.org.uk>
[...]
> void __init prom_free_prom_memory(void)
> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
> index c591f69..76a358e 100644
> --- a/arch/mips/ar7/platform.c
> +++ b/arch/mips/ar7/platform.c
> @@ -42,39 +42,42 @@
> #include <asm/mach-ar7/gpio.h>
> #include <asm/mach-ar7/prom.h>
>
> +/*****************************************************************************
> + * VLYNQ Bus
> + ****************************************************************************/
Why not simply use:
/* VLYNQ Bus */
You have deleted lots of whitespaces, but added more *.
[...]
> +/*****************************************************************************
> + * Flash
> + ****************************************************************************/
[...]
> +
> +/*****************************************************************************
> + * Ethernet
> + ****************************************************************************/
[...]
> +
> +/*****************************************************************************
> + * USB
> + ****************************************************************************/
> +
[...]
>
> +/*****************************************************************************
> + * LEDs
> + ****************************************************************************/
[...]
> +/*****************************************************************************
> + * Watchdog
> + ****************************************************************************/
[...]
> +
> +/*****************************************************************************
> + * Init
> + ****************************************************************************/
[...]
>
> @@ -70,7 +71,6 @@ console_initcall(ar7_init_console);
> * Initializes basic routines and structures pointers, memory size (as
> * given by the bios and saves the command line.
> */
> -
> void __init plat_mem_setup(void)
> {
> unsigned long io_base;
> @@ -88,6 +88,5 @@ void __init plat_mem_setup(void)
> prom_meminit();
>
> printk(KERN_INFO "%s, ID: 0x%04x, Revision: 0x%02x\n",
> - get_system_type(),
> - ar7_chip_id(), ar7_chip_rev());
> + get_system_type(), ar7_chip_id(), ar7_chip_rev());
> }
Perhaps you can use pr_info() instead of printk(KERN_INFO) too, of
course, if there are more printk(KERN_...), you can replace them by
pr_xxx defined in include/linux/kernel.h
Best Regards,
Wu Zhangjin
next prev parent reply other threads:[~2010-02-01 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 19:38 [PATCH 1/3] MIPS: AR7 whitespace hacking Alexander Clouter
2010-02-01 6:29 ` Wu Zhangjin [this message]
2010-02-01 10:03 ` Alexander Clouter
2010-02-01 17:45 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265005758.31984.8.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=alex@digriz.org.uk \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox