From: Ralf Baechle <ralf@linux-mips.org>
To: Alexander Clouter <alex@digriz.org.uk>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] MIPS: AR7 whitespace hacking
Date: Mon, 1 Feb 2010 18:45:12 +0100 [thread overview]
Message-ID: <20100201174512.GA9806@linux-mips.org> (raw)
In-Reply-To: <1hli37-4t9.ln1@chipmunk.wormnet.eu>
On Mon, Feb 01, 2010 at 10:03:45AM +0000, Alexander Clouter wrote:
> From: Alexander Clouter <alex@digriz.org.uk>
> Date: Mon, 1 Feb 2010 10:03:45 +0000
> To: linux-mips@linux-mips.org
> Subject: Re: [PATCH 1/3] MIPS: AR7 whitespace hacking
>
> Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> >
> >> +/*****************************************************************************
> >> + * VLYNQ Bus
> >> + ****************************************************************************/
> >
> > Why not simply use:
> >
> > /* VLYNQ Bus */
> >
> > You have deleted lots of whitespaces, but added more *.
> >
> "good enough for ARM[1]" :)
>
> Compromise on this instead?
> ----
> /*
> * VLYNQ Bus
> */
> ----
Just did this one myself.
The patch also had a reject on the lest segment of arch/mips/ar7/prom.c.rej;
it seems that you've not created your patches against a recent version
of the -queue tree. Either way, queued for 2.6.34.
Ralf
prev parent reply other threads:[~2010-02-01 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 19:38 [PATCH 1/3] MIPS: AR7 whitespace hacking Alexander Clouter
2010-02-01 6:29 ` Wu Zhangjin
2010-02-01 10:03 ` Alexander Clouter
2010-02-01 17:45 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201174512.GA9806@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alex@digriz.org.uk \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox