From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 4/5] MIPS: delete bogus module.h usage in termios.h
Date: Tue, 28 Feb 2012 14:24:47 -0500 [thread overview]
Message-ID: <1330457088-14587-5-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1330457088-14587-1-git-send-email-paul.gortmaker@windriver.com>
There is no need for this. Removing it causes a small amount
of fallout (shown below) due to a few implicit header presence
assumptions that are easily fixed.
arch/mips/include/asm/termios.h:103: error: implicit declaration of function 'access_ok'
arch/mips/include/asm/module.h:17: error: expected specifier-qualifier-list before 'Elf64_Addr'
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
arch/mips/include/asm/module.h | 1 +
arch/mips/include/asm/termios.h | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/mips/include/asm/module.h b/arch/mips/include/asm/module.h
index 7467d1d..5300080 100644
--- a/arch/mips/include/asm/module.h
+++ b/arch/mips/include/asm/module.h
@@ -2,6 +2,7 @@
#define _ASM_MODULE_H
#include <linux/list.h>
+#include <linux/elf.h>
#include <asm/uaccess.h>
struct mod_arch_specific {
diff --git a/arch/mips/include/asm/termios.h b/arch/mips/include/asm/termios.h
index 8f77f77..abdd87a 100644
--- a/arch/mips/include/asm/termios.h
+++ b/arch/mips/include/asm/termios.h
@@ -60,7 +60,7 @@ struct termio {
};
#ifdef __KERNEL__
-#include <linux/module.h>
+#include <asm/uaccess.h>
/*
* intr=^C quit=^\ erase=del kill=^U
--
1.7.9.1
next prev parent reply other threads:[~2012-02-28 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 19:24 [PATCH 0/5] MIPS: module.h usage cleanup Paul Gortmaker
2012-02-28 19:24 ` [PATCH 1/5] serial: MIPS DECstation zs.c driver needs module.h Paul Gortmaker
2012-02-28 19:24 ` [PATCH 2/5] serial: MIPS swarm sb1250-duart.c " Paul Gortmaker
2012-02-28 19:24 ` [PATCH 3/5] MIPS: fix several implicit uses of export.h/module.h Paul Gortmaker
2012-02-28 19:24 ` Paul Gortmaker [this message]
2012-02-28 19:24 ` [PATCH 5/5] MIPS: dont use module.h just to export symbols in asm/uasm.h Paul Gortmaker
2012-03-06 19:08 ` [PATCH 0/5] MIPS: module.h usage cleanup Ralf Baechle
2012-03-06 19:20 ` Paul Gortmaker
2012-03-06 19:20 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330457088-14587-5-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox