From: Ian Campbell <ian.campbell@citrix.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>
Cc: Yijing Wang <wangyijing@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>, <linux-mips@linux-mips.org>,
<linux-ia64@vger.kernel.org>, <linux-sh@vger.kernel.org>,
<linux-pci@vger.kernel.org>, Chris Metcalf <cmetcalf@ezchip.com>,
Paul Mackerras <paulus@samba.org>, <sparclinux@vger.kernel.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>, <linux-s390@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Michael Ellerman <mpe@ellerman.id.au>, <x86@kernel.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
<linux-arm-kernel@lists.infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
<xen-devel@lists.xenproject.org>,
Matt Turner <mattst88@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
<linux-m68k@lists.linux-m68k.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
"Yinghai Lu" <yinghai@kernel.org>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Richard Henderson <rth@twiddle.net>,
Liviu Dudau <liviu@dudau.co.uk>, Michal Simek <monstr@monstr.eu>,
Tony Luck <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
"David S. Miller" <davem@davemloft.net>,
<linux-alpha@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
Jiang Liu <jiang.liu@linux.intel.com>
Subject: Re: [Xen-devel] [PATCH v6 07/30] PCI: Pass PCI domain number combined with root bus number
Date: Tue, 17 Mar 2015 14:05:30 +0000 [thread overview]
Message-ID: <1426601130.18247.238.camel@citrix.com> (raw)
In-Reply-To: <5507B88D.1020300@caviumnetworks.com>
On Tue, 2015-03-17 at 10:45 +0530, Manish Jaggi wrote:
> On Monday 09 March 2015 08:04 AM, Yijing Wang wrote:
> > Now we could pass PCI domain combined with bus number
> > in u32 argu. Because in arm/arm64, PCI domain number
> > is assigned by pci_bus_assign_domain_nr(). So we leave
> > pci_scan_root_bus() and pci_create_root_bus() in arm/arm64
> > unchanged. A new function pci_host_assign_domain_nr()
> > will be introduced for arm/arm64 to assign domain number
> > in later patch.
> Hi,
> I think these changes might not be required. We have made very few
> changes in the xen-pcifront to support PCI passthrough in arm64.
> As per xen architecture for a domU only a single pci virtual bus is
> created and all passthrough devices are attached to it.
I guess you are only talking about the changes to xen-pcifront.c?
Otherwise you are ignoring the dom0 case which is exposed to the real
set of PCI root complexes and anyway I'm not sure how "not needed for
Xen domU" translates into not required, since it is clearly required for
other systems.
Strictly speaking the Xen pciif protocol does support multiple buses,
it's just that the tools, and perhaps kernels, have not yet felt any
need to actually make use of that.
There doesn't seem to be any harm in updating pcifront to follow this
generic API change.
Ian.
WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <ian.campbell@citrix.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>
Cc: Yijing Wang <wangyijing@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, linux-pci@vger.kernel.org,
Chris Metcalf <cmetcalf@ezchip.com>,
Paul Mackerras <paulus@samba.org>,
sparclinux@vger.kernel.org, Guan Xuetao <gxt@mprc.pku.edu.cn>,
linux-s390@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Michael Ellerman <mpe@ellerman.id.au>,
x86@kernel.org, Sebastian Ott <sebott@linux.vnet.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
xen-devel@lists.xenproject.org, Matt Turner <mattst88@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-m68k@lists.linux-m68k.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Richard Henderson <rth@twiddle.net>,
Liviu Dudau <liviu@dudau.co.uk>, Michal Simek <monstr@monstr.eu>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
"David S. Miller" <davem@davemloft.net>,
linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Jiang Liu <jiang.liu@linux.intel.com>
Subject: Re: [Xen-devel] [PATCH v6 07/30] PCI: Pass PCI domain number combined with root bus number
Date: Tue, 17 Mar 2015 14:05:30 +0000 [thread overview]
Message-ID: <1426601130.18247.238.camel@citrix.com> (raw)
Message-ID: <20150317140530.VXnNdohX7rFCzIHoGS2NYHfU5cALy13iSLhf2-aWuGw@z> (raw)
In-Reply-To: <5507B88D.1020300@caviumnetworks.com>
On Tue, 2015-03-17 at 10:45 +0530, Manish Jaggi wrote:
> On Monday 09 March 2015 08:04 AM, Yijing Wang wrote:
> > Now we could pass PCI domain combined with bus number
> > in u32 argu. Because in arm/arm64, PCI domain number
> > is assigned by pci_bus_assign_domain_nr(). So we leave
> > pci_scan_root_bus() and pci_create_root_bus() in arm/arm64
> > unchanged. A new function pci_host_assign_domain_nr()
> > will be introduced for arm/arm64 to assign domain number
> > in later patch.
> Hi,
> I think these changes might not be required. We have made very few
> changes in the xen-pcifront to support PCI passthrough in arm64.
> As per xen architecture for a domU only a single pci virtual bus is
> created and all passthrough devices are attached to it.
I guess you are only talking about the changes to xen-pcifront.c?
Otherwise you are ignoring the dom0 case which is exposed to the real
set of PCI root complexes and anyway I'm not sure how "not needed for
Xen domU" translates into not required, since it is clearly required for
other systems.
Strictly speaking the Xen pciif protocol does support multiple buses,
it's just that the tools, and perhaps kernels, have not yet felt any
need to actually make use of that.
There doesn't seem to be any harm in updating pcifront to follow this
generic API change.
Ian.
next prev parent reply other threads:[~2015-03-17 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1425868467-9667-1-git-send-email-wangyijing@huawei.com>
2015-03-09 2:33 ` [PATCH v6 02/30] PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus() Yijing Wang
2015-03-09 2:33 ` Yijing Wang
2015-03-09 2:34 ` [PATCH v6 07/30] PCI: Pass PCI domain number combined with root bus number Yijing Wang
2015-03-09 2:34 ` Yijing Wang
2015-03-12 1:34 ` Bjorn Helgaas
2015-03-12 12:20 ` Yijing Wang
2015-03-12 12:20 ` Yijing Wang
2015-03-17 5:15 ` [Xen-devel] " Manish Jaggi
2015-03-17 5:15 ` Manish Jaggi
2015-03-17 14:05 ` Ian Campbell [this message]
2015-03-17 14:05 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426601130.18247.238.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=cmetcalf@ezchip.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=ink@jurassic.park.msu.ru \
--cc=jiang.liu@linux.intel.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liviu@dudau.co.uk \
--cc=marc.zyngier@arm.com \
--cc=mattst88@gmail.com \
--cc=mjaggi@caviumnetworks.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=rusty@rustcorp.com.au \
--cc=sebott@linux.vnet.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wangyijing@huawei.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox