* [PATCH 1/2] MIPS: SMP-CPS: Remove duplicate assignment of core in play_dead
@ 2017-12-15 9:34 Matt Redfearn
2017-12-15 9:34 ` Matt Redfearn
2017-12-15 9:34 ` [PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating Matt Redfearn
0 siblings, 2 replies; 4+ messages in thread
From: Matt Redfearn @ 2017-12-15 9:34 UTC (permalink / raw)
To: Ralf Baechle, jhogan
Cc: linux-mips, Matt Redfearn, Dengcheng Zhu, linux-kernel,
Paul Burton, Ingo Molnar
The merge of commit f875a832d2028 ("MIPS: Abstract CPU core & VP(E) ID
access through accessor functions") ended up creating a duplicate
assignment of core during the rebase on commit bac06cf0fb9d ("MIPS:
smp-cps: Fix potentially uninitialised value of core"). Remove the
duplicate.
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
arch/mips/kernel/smp-cps.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index ecc1a853f48d..03f1026ad148 100644
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -439,8 +439,6 @@ void play_dead(void)
pr_debug("CPU%d going offline\n", cpu);
if (cpu_has_mipsmt || cpu_has_vp) {
- core = cpu_core(&cpu_data[cpu]);
-
/* Look for another online VPE within the core */
for_each_online_cpu(cpu_death_sibling) {
if (!cpus_are_siblings(cpu, cpu_death_sibling))
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/2] MIPS: SMP-CPS: Remove duplicate assignment of core in play_dead
2017-12-15 9:34 [PATCH 1/2] MIPS: SMP-CPS: Remove duplicate assignment of core in play_dead Matt Redfearn
@ 2017-12-15 9:34 ` Matt Redfearn
2017-12-15 9:34 ` [PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating Matt Redfearn
1 sibling, 0 replies; 4+ messages in thread
From: Matt Redfearn @ 2017-12-15 9:34 UTC (permalink / raw)
To: Ralf Baechle, jhogan
Cc: linux-mips, Matt Redfearn, Dengcheng Zhu, linux-kernel,
Paul Burton, Ingo Molnar
The merge of commit f875a832d2028 ("MIPS: Abstract CPU core & VP(E) ID
access through accessor functions") ended up creating a duplicate
assignment of core during the rebase on commit bac06cf0fb9d ("MIPS:
smp-cps: Fix potentially uninitialised value of core"). Remove the
duplicate.
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
arch/mips/kernel/smp-cps.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index ecc1a853f48d..03f1026ad148 100644
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -439,8 +439,6 @@ void play_dead(void)
pr_debug("CPU%d going offline\n", cpu);
if (cpu_has_mipsmt || cpu_has_vp) {
- core = cpu_core(&cpu_data[cpu]);
-
/* Look for another online VPE within the core */
for_each_online_cpu(cpu_death_sibling) {
if (!cpus_are_siblings(cpu, cpu_death_sibling))
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating
2017-12-15 9:34 [PATCH 1/2] MIPS: SMP-CPS: Remove duplicate assignment of core in play_dead Matt Redfearn
2017-12-15 9:34 ` Matt Redfearn
@ 2017-12-15 9:34 ` Matt Redfearn
2017-12-15 9:34 ` Matt Redfearn
1 sibling, 1 reply; 4+ messages in thread
From: Matt Redfearn @ 2017-12-15 9:34 UTC (permalink / raw)
To: Ralf Baechle, jhogan
Cc: linux-mips, Matt Redfearn, Dengcheng Zhu, linux-kernel,
Thomas Gleixner, Paul Burton, Mark Rutland
If a JTAG probe is connected to a MIPS cluster, then the CPC detects it
and latches the CPC.STAT_CONF.EJTAG_PROBE bit to 1. While set,
attempting to send a power-down command to a core will be blocked, and
the CPC will instead send the core to clock-off state. This can
interfere with systems fully entering a low power state where all cores,
CM, GIC, etc are powered down.
Detect that a JTAG probe is / has been connected to the cluster and emit
a warning that the attempted power down will fail, to aid debugging
system suspend where it is not currently obvious that a core has not
really powered down and will block a full power down of the cluster. We
use a ratelimited pr_warn since this path will also be hit by cpu idle
if it attempts to put cores into the powered down state.
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
arch/mips/kernel/pm-cps.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/mips/kernel/pm-cps.c b/arch/mips/kernel/pm-cps.c
index 421e06dfee72..45776613a5be 100644
--- a/arch/mips/kernel/pm-cps.c
+++ b/arch/mips/kernel/pm-cps.c
@@ -11,6 +11,7 @@
#include <linux/cpuhotplug.h>
#include <linux/init.h>
#include <linux/percpu.h>
+#include <linux/ratelimit.h>
#include <linux/slab.h>
#include <asm/asm-offsets.h>
@@ -143,6 +144,18 @@ int cps_pm_enter_state(enum cps_pm_state state)
/* Setup the VPE to run mips_cps_pm_restore when started again */
if (IS_ENABLED(CONFIG_CPU_PM) && state == CPS_PM_POWER_GATED) {
+ unsigned int stat = read_cpc_cl_stat_conf();
+
+ if (stat & CPC_Cx_STAT_CONF_EJTAG_PROBE) {
+ /*
+ * If we're attempting to gate power to the core, the
+ * JTAG detect bit indicates that the CPC will instead
+ * put the core into clock-off state. Emit a warning.
+ */
+ pr_warn_ratelimited("JTAG probe present - core%d will clock off instead of powering down\n",
+ core);
+ }
+
/* Power gating relies upon CPS SMP */
if (!mips_cps_smp_in_use())
return -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating
2017-12-15 9:34 ` [PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating Matt Redfearn
@ 2017-12-15 9:34 ` Matt Redfearn
0 siblings, 0 replies; 4+ messages in thread
From: Matt Redfearn @ 2017-12-15 9:34 UTC (permalink / raw)
To: Ralf Baechle, jhogan
Cc: linux-mips, Matt Redfearn, Dengcheng Zhu, linux-kernel,
Thomas Gleixner, Paul Burton, Mark Rutland
If a JTAG probe is connected to a MIPS cluster, then the CPC detects it
and latches the CPC.STAT_CONF.EJTAG_PROBE bit to 1. While set,
attempting to send a power-down command to a core will be blocked, and
the CPC will instead send the core to clock-off state. This can
interfere with systems fully entering a low power state where all cores,
CM, GIC, etc are powered down.
Detect that a JTAG probe is / has been connected to the cluster and emit
a warning that the attempted power down will fail, to aid debugging
system suspend where it is not currently obvious that a core has not
really powered down and will block a full power down of the cluster. We
use a ratelimited pr_warn since this path will also be hit by cpu idle
if it attempts to put cores into the powered down state.
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
arch/mips/kernel/pm-cps.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/mips/kernel/pm-cps.c b/arch/mips/kernel/pm-cps.c
index 421e06dfee72..45776613a5be 100644
--- a/arch/mips/kernel/pm-cps.c
+++ b/arch/mips/kernel/pm-cps.c
@@ -11,6 +11,7 @@
#include <linux/cpuhotplug.h>
#include <linux/init.h>
#include <linux/percpu.h>
+#include <linux/ratelimit.h>
#include <linux/slab.h>
#include <asm/asm-offsets.h>
@@ -143,6 +144,18 @@ int cps_pm_enter_state(enum cps_pm_state state)
/* Setup the VPE to run mips_cps_pm_restore when started again */
if (IS_ENABLED(CONFIG_CPU_PM) && state == CPS_PM_POWER_GATED) {
+ unsigned int stat = read_cpc_cl_stat_conf();
+
+ if (stat & CPC_Cx_STAT_CONF_EJTAG_PROBE) {
+ /*
+ * If we're attempting to gate power to the core, the
+ * JTAG detect bit indicates that the CPC will instead
+ * put the core into clock-off state. Emit a warning.
+ */
+ pr_warn_ratelimited("JTAG probe present - core%d will clock off instead of powering down\n",
+ core);
+ }
+
/* Power gating relies upon CPS SMP */
if (!mips_cps_smp_in_use())
return -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-15 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 9:34 [PATCH 1/2] MIPS: SMP-CPS: Remove duplicate assignment of core in play_dead Matt Redfearn
2017-12-15 9:34 ` Matt Redfearn
2017-12-15 9:34 ` [PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating Matt Redfearn
2017-12-15 9:34 ` Matt Redfearn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox