Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Hiroyuki Machida <machida@sm.sony.co.jp>
To: unlisted-recipients:; (no To-header on input)
Cc: linux@cthulhu.engr.sgi.com, debian-mips@lists.debian.org
Subject: Re: MIPS gas problem
Date: Mon, 24 Apr 2000 12:16:51 +0900	[thread overview]
Message-ID: <20000424121651S.machida@sm.sony.co.jp> (raw)
In-Reply-To: <20000421154859.3820.qmail@daffy.airs.com>


Thank you Ian and Alan.

From: Ian Lance Taylor <ian@zembu.com>
Subject: Re: MIPS gas problem
Date: 21 Apr 2000 08:48:59 -0700

>    Date: Fri, 21 Apr 2000 12:30:14 +0900
>    From: Hiroyuki Machida <machida@sm.sony.co.jp>
> 
>    This message is a gcc issue, as you said. 
> 
>    But, my reported plobelm is really binutils issue.
> 
> I know.  I didn't mean to imply otherwise.  Alan Modra's suggested
> patch was the right one.
> 
> Ian

I summarize the problem and attach patch. Please install it, if you
can. I don't know what procedure is required to install the patch to
CVS tree. 

*Problem Description:
Current tc-mips.c:s_change_sec() always sets '.rdata' and '.sdata'
section alignments to 2**4, even if those contain over 2**4 aligned 
objects.


*Solution:
Tc-mips.c:s_change_sec() should use record_alignment(), not
bfd_set_section_alignment(), for preventing  reset section
alignments.


*Patch:

2000-04-24	Machida Hiroyuki <machida@sm.sony.co.jp>

tc-mips.c (s_change_sec): Use record_alignment(), not 
  bfd_set_section_alignment() to preserve section aligenments. 


--- tc-mips.c.ORG	Mon Apr 24 11:22:39 2000
+++ tc-mips.c	Mon Apr 24 11:24:48 2000
@@ -10045,7 +10045,7 @@ s_change_sec (sec)
 				      | SEC_RELOC
 				      | SEC_DATA));
 	      if (strcmp (TARGET_OS, "elf") != 0)
-		bfd_set_section_alignment (stdoutput, seg, 4);
+		record_alignment (stdoutput, seg, 4);
 	    }
 	  demand_empty_rest_of_line ();
 	}
@@ -10067,7 +10067,7 @@ s_change_sec (sec)
 				     SEC_ALLOC | SEC_LOAD | SEC_RELOC
 				     | SEC_DATA);
 	      if (strcmp (TARGET_OS, "elf") != 0)
-		bfd_set_section_alignment (stdoutput, seg, 4);
+		record_alignment (stdoutput, seg, 4);
 	    }
 	  demand_empty_rest_of_line ();
 	  break;

WARNING: multiple messages have this Message-ID (diff)
From: Hiroyuki Machida <machida@sm.sony.co.jp>
Cc: linux@cthulhu.engr.sgi.com, debian-mips@lists.debian.org
Subject: Re: MIPS gas problem
Date: Mon, 24 Apr 2000 12:16:51 +0900	[thread overview]
Message-ID: <20000424121651S.machida@sm.sony.co.jp> (raw)
Message-ID: <20000424031651.JPEuzVb0Bwk6rWVTeHLuhTelvCUf4f1wGHutoVJnBfw@z> (raw)
In-Reply-To: <20000421154859.3820.qmail@daffy.airs.com>


Thank you Ian and Alan.

From: Ian Lance Taylor <ian@zembu.com>
Subject: Re: MIPS gas problem
Date: 21 Apr 2000 08:48:59 -0700

>    Date: Fri, 21 Apr 2000 12:30:14 +0900
>    From: Hiroyuki Machida <machida@sm.sony.co.jp>
> 
>    This message is a gcc issue, as you said. 
> 
>    But, my reported plobelm is really binutils issue.
> 
> I know.  I didn't mean to imply otherwise.  Alan Modra's suggested
> patch was the right one.
> 
> Ian

I summarize the problem and attach patch. Please install it, if you
can. I don't know what procedure is required to install the patch to
CVS tree. 

*Problem Description:
Current tc-mips.c:s_change_sec() always sets '.rdata' and '.sdata'
section alignments to 2**4, even if those contain over 2**4 aligned 
objects.


*Solution:
Tc-mips.c:s_change_sec() should use record_alignment(), not
bfd_set_section_alignment(), for preventing  reset section
alignments.


*Patch:

2000-04-24	Machida Hiroyuki <machida@sm.sony.co.jp>

tc-mips.c (s_change_sec): Use record_alignment(), not 
  bfd_set_section_alignment() to preserve section aligenments. 


--- tc-mips.c.ORG	Mon Apr 24 11:22:39 2000
+++ tc-mips.c	Mon Apr 24 11:24:48 2000
@@ -10045,7 +10045,7 @@ s_change_sec (sec)
 				      | SEC_RELOC
 				      | SEC_DATA));
 	      if (strcmp (TARGET_OS, "elf") != 0)
-		bfd_set_section_alignment (stdoutput, seg, 4);
+		record_alignment (stdoutput, seg, 4);
 	    }
 	  demand_empty_rest_of_line ();
 	}
@@ -10067,7 +10067,7 @@ s_change_sec (sec)
 				     SEC_ALLOC | SEC_LOAD | SEC_RELOC
 				     | SEC_DATA);
 	      if (strcmp (TARGET_OS, "elf") != 0)
-		bfd_set_section_alignment (stdoutput, seg, 4);
+		record_alignment (stdoutput, seg, 4);
 	    }
 	  demand_empty_rest_of_line ();
 	  break;

  parent reply	other threads:[~2000-04-24  3:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-04-20  2:13 MIPS gas problem Hiroyuki Machida
2000-04-20 10:16 ` Florian Lohoff
2000-04-20 12:07 ` Koundinya.K
     [not found]   ` <20000420164812.17210.qmail@daffy.airs.com>
2000-04-21  1:52     ` Hiroyuki Machida
2000-04-24  5:06       ` Koundinya.K
2000-04-21  3:30     ` Hiroyuki Machida
     [not found]       ` <20000421154859.3820.qmail@daffy.airs.com>
2000-04-24  3:16         ` Hiroyuki Machida [this message]
2000-04-24  3:16           ` Hiroyuki Machida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20000424121651S.machida@sm.sony.co.jp \
    --to=machida@sm.sony.co.jp \
    --cc=debian-mips@lists.debian.org \
    --cc=linux@cthulhu.engr.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox