From: Ralf Baechle <ralf@oss.sgi.com>
To: Jun Sun <jsun@mvista.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: missing data cache flush in trap_init?
Date: Wed, 3 Jan 2001 15:05:35 -0200 [thread overview]
Message-ID: <20010103150535.B904@bacchus.dhis.org> (raw)
In-Reply-To: <3A5277C6.89170BAD@mvista.com>; from jsun@mvista.com on Tue, Jan 02, 2001 at 04:52:22PM -0800
On Tue, Jan 02, 2001 at 04:52:22PM -0800, Jun Sun wrote:
> Someone reported this bug to me. I think it is a valid one. Basically
> trap_init() installs the vectors through kseg0 address and then flushes
> icache. It is possible that the vectors are still in the data cache and not
> written back to memory yet. If an exception happens it may get the corrupted
> the vector value.
>
> The following patch should fix it. I am not sure if I can use
> flush_cache_range() to have potentially better performance.
Flush_icache_range is correct; the function is expected to do any dcache
writebacks etc. to make dcache / icache / memory coherent.
Is it possible that you're using a CPU with additional vectors that aren't
flushed by this flush_icache_call or?
Ralf
next prev parent reply other threads:[~2001-01-03 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-03 0:52 missing data cache flush in trap_init? Jun Sun
2001-01-03 11:29 ` Maciej W. Rozycki
2001-01-03 17:05 ` Ralf Baechle [this message]
2001-01-04 3:26 ` Jun Sun
2001-01-04 17:25 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010103150535.B904@bacchus.dhis.org \
--to=ralf@oss.sgi.com \
--cc=jsun@mvista.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox