Linux MIPS Architecture development
 help / color / mirror / Atom feed
* get_insn_opcode is broken (ll/sc emulation does not work)
@ 2001-08-24  8:06 Atsushi Nemoto
  2001-08-24 11:28 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2001-08-24  8:06 UTC (permalink / raw)
  To: linux-mips, linux-mips; +Cc: Ralf Baechle

I found that get_insn_opcode(in traps.c) is broken.


static inline int get_insn_opcode(struct pt_regs *regs, unsigned int *opcode)
...
	if (!get_user(opcode, epc))


This must be:


static inline int get_insn_opcode(struct pt_regs *regs, unsigned int *opcode)
...
	if (!get_user(*opcode, epc))


Without this fix, ll/sc emulation might not work.

---
Atsushi Nemoto

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-08-24 11:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-24  8:06 get_insn_opcode is broken (ll/sc emulation does not work) Atsushi Nemoto
2001-08-24 11:28 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox