Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@oss.sgi.com>
To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Cc: linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: scall_o32.S in 2.4.6 (or later)
Date: Mon, 27 Aug 2001 08:30:17 +0200	[thread overview]
Message-ID: <20010827083017.A2689@dea.linux-mips.net> (raw)
In-Reply-To: <20010827.101340.74756473.nemoto@toshiba-tops.co.jp>; from nemoto@toshiba-tops.co.jp on Mon, Aug 27, 2001 at 10:13:40AM +0900

On Mon, Aug 27, 2001 at 10:13:40AM +0900, Atsushi Nemoto wrote:

> After merging with 2.4.6, it seems that syscall destroy static
> registers.  Isnt't this needed?

Only if you insist on keeping register contents ;-)

The SAVE_STATIC was actually there, just at the wrong place, so the correct
patch is below.

Index: arch/mips/kernel/scall_o32.S
===================================================================
RCS file: /home/pub/cvs/linux/arch/mips/kernel/scall_o32.S,v
retrieving revision 1.16
diff -u -r1.16 scall_o32.S
--- arch/mips/kernel/scall_o32.S	2001/08/22 03:23:59	1.16
+++ arch/mips/kernel/scall_o32.S	2001/08/27 06:31:46
@@ -86,13 +86,13 @@
 	ori	t0, t0, 1
 	mtc0	t0, CP0_STATUS
 
+	SAVE_STATIC
 	move	a0, zero
 	move	a1, sp
 	jal	do_signal
 	b	restore_all
 
 o32_reschedule:
-	SAVE_STATIC
 	jal	schedule
 	b	o32_ret_from_sys_call
 

  Ralf

      reply	other threads:[~2001-08-27  6:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-27  1:13 scall_o32.S in 2.4.6 (or later) Atsushi Nemoto
2001-08-27  6:30 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010827083017.A2689@dea.linux-mips.net \
    --to=ralf@oss.sgi.com \
    --cc=linux-mips@fnet.fr \
    --cc=linux-mips@oss.sgi.com \
    --cc=nemoto@toshiba-tops.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox