Linux MIPS Architecture development
 help / color / mirror / Atom feed
* scall_o32.S in 2.4.6 (or later)
@ 2001-08-27  1:13 Atsushi Nemoto
  2001-08-27  6:30 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2001-08-27  1:13 UTC (permalink / raw)
  To: linux-mips, linux-mips; +Cc: Ralf Baechle

After merging with 2.4.6, it seems that syscall destroy static
registers.  Isnt't this needed?

diff -ur linux.sgi/arch/mips/kernel/scall_o32.S linux/arch/mips/kernel/scall_o32.S
--- linux.sgi/arch/mips/kernel/scall_o32.S	Mon Aug 27 10:03:56 2001
+++ linux/arch/mips/kernel/scall_o32.S	Mon Aug 27 10:04:21 2001
@@ -88,6 +88,7 @@
 
 	move	a0, zero
 	move	a1, sp
+ 	SAVE_STATIC
 	jal	do_signal
 	b	restore_all
 
---
Atsushi Nemoto

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: scall_o32.S in 2.4.6 (or later)
  2001-08-27  1:13 scall_o32.S in 2.4.6 (or later) Atsushi Nemoto
@ 2001-08-27  6:30 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2001-08-27  6:30 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips, linux-mips

On Mon, Aug 27, 2001 at 10:13:40AM +0900, Atsushi Nemoto wrote:

> After merging with 2.4.6, it seems that syscall destroy static
> registers.  Isnt't this needed?

Only if you insist on keeping register contents ;-)

The SAVE_STATIC was actually there, just at the wrong place, so the correct
patch is below.

Index: arch/mips/kernel/scall_o32.S
===================================================================
RCS file: /home/pub/cvs/linux/arch/mips/kernel/scall_o32.S,v
retrieving revision 1.16
diff -u -r1.16 scall_o32.S
--- arch/mips/kernel/scall_o32.S	2001/08/22 03:23:59	1.16
+++ arch/mips/kernel/scall_o32.S	2001/08/27 06:31:46
@@ -86,13 +86,13 @@
 	ori	t0, t0, 1
 	mtc0	t0, CP0_STATUS
 
+	SAVE_STATIC
 	move	a0, zero
 	move	a1, sp
 	jal	do_signal
 	b	restore_all
 
 o32_reschedule:
-	SAVE_STATIC
 	jal	schedule
 	b	o32_ret_from_sys_call
 

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-08-27  6:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-27  1:13 scall_o32.S in 2.4.6 (or later) Atsushi Nemoto
2001-08-27  6:30 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox