From: Ralf Baechle <ralf@oss.sgi.com>
To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Cc: linux-mips@oss.sgi.com
Subject: Re: setup_frame() failure
Date: Thu, 13 Sep 2001 03:11:19 +0200 [thread overview]
Message-ID: <20010913031119.B27168@dea.linux-mips.net> (raw)
In-Reply-To: <20010912.130914.112630116.nemoto@toshiba-tops.co.jp>; from nemoto@toshiba-tops.co.jp on Wed, Sep 12, 2001 at 01:09:14PM +0900
On Wed, Sep 12, 2001 at 01:09:14PM +0900, Atsushi Nemoto wrote:
> nemoto> But, does not a debugger confused by skipping the instruction
> nemoto> which cause Trap or Breakpoint exception? (I do not know much
> nemoto> about communication between kernel and debugger...)
>
> I tried same fix for Trap exception (I inserted compute_return_epc()
> before force_sig(SIGTRAP, current) line in do_tr()). With this fix,
> gdb did not work correctly.
>
> So we should take another fix (at least for Trap exception) ?
Below a fix. It's not the real thing but at least solved the problem
pretty reliable as normal compiler generated code will never place trap
and break instructions in delay slots. The actual fix should be skipping
over the faulting instruction when returning from the signal handler.
Ralf
Index: arch/mips64/kernel/traps.c
===================================================================
RCS file: /home/pub/cvs/linux/arch/mips64/kernel/traps.c,v
retrieving revision 1.21
diff -u -r1.21 traps.c
--- arch/mips64/kernel/traps.c 2001/09/07 23:35:57 1.21
+++ arch/mips64/kernel/traps.c 2001/09/13 01:01:25
@@ -291,7 +291,7 @@
info.si_code = FPE_INTOVF;
info.si_signo = SIGFPE;
info.si_errno = 0;
- info.si_addr = (void *)compute_return_epc(regs);
+ info.si_addr = (void *)regs->cp0_epc;
force_sig_info(SIGFPE, &info, current);
break;
default:
@@ -333,7 +333,7 @@
info.si_code = FPE_INTOVF;
info.si_signo = SIGFPE;
info.si_errno = 0;
- info.si_addr = (void *)compute_return_epc(regs);
+ info.si_addr = (void *)regs->cp0_epc;
force_sig_info(SIGFPE, &info, current);
break;
default:
Index: arch/mips/kernel/traps.c
===================================================================
RCS file: /home/pub/cvs/linux/arch/mips/kernel/traps.c,v
retrieving revision 1.79
diff -u -r1.79 traps.c
--- arch/mips/kernel/traps.c 2001/09/07 23:35:57 1.79
+++ arch/mips/kernel/traps.c 2001/09/13 01:01:25
@@ -424,7 +424,7 @@
info.si_code = FPE_INTOVF;
info.si_signo = SIGFPE;
info.si_errno = 0;
- info.si_addr = (void *)compute_return_epc(regs);
+ info.si_addr = (void *)regs->cp0_epc;
force_sig_info(SIGFPE, &info, current);
break;
default:
@@ -464,7 +464,7 @@
info.si_code = FPE_INTOVF;
info.si_signo = SIGFPE;
info.si_errno = 0;
- info.si_addr = (void *)compute_return_epc(regs);
+ info.si_addr = (void *)regs->cp0_epc;
force_sig_info(SIGFPE, &info, current);
break;
default:
next prev parent reply other threads:[~2001-09-13 1:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-07 11:26 setup_frame() failure Atsushi Nemoto
2001-09-07 23:36 ` Ralf Baechle
2001-09-10 2:44 ` Atsushi Nemoto
2001-09-12 4:09 ` Atsushi Nemoto
2001-09-13 1:11 ` Ralf Baechle [this message]
2001-09-14 2:16 ` Atsushi Nemoto
2001-09-14 20:14 ` Ralf Baechle
2001-09-17 3:28 ` Atsushi Nemoto
2001-09-10 7:28 ` Carsten Langgaard
2001-09-10 9:19 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010913031119.B27168@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=linux-mips@oss.sgi.com \
--cc=nemoto@toshiba-tops.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox