Linux MIPS Architecture development
 help / color / mirror / Atom feed
* 1$ clobber bug
@ 2001-11-06 19:19 James Simmons
  0 siblings, 0 replies; 3+ messages in thread
From: James Simmons @ 2001-11-06 19:19 UTC (permalink / raw)
  To: linux-mips



I believe the ITE generic time code has a 1$ clobber bug in it. Here is a
patch to fix this.

--- time.c	Fri Oct  5 10:01:22 2001
+++ /usr/src/linux/arch/mips/ite-boards/generic/time.c	Tue Nov  6 11:38:00 2001
@@ -303,7 +303,8 @@
 			:"r" (timerhi),
 			 "m" (timerlo),
 			 "r" (tmp),
-			 "r" (USECS_PER_JIFFY));
+			 "r" (USECS_PER_JIFFY)
+			:"$1");
 		cached_quotient = quotient;
 	}
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: 1$ clobber bug
@ 2001-11-06 19:44 James Simmons
  2001-11-06 21:05 ` Ralf Baechle
  0 siblings, 1 reply; 3+ messages in thread
From: James Simmons @ 2001-11-06 19:44 UTC (permalink / raw)
  To: linux-mips



Sorry I got the patch backwards. It seems that the standard 2.4.14 tree
some how missed the $1 clobber fixes but it merged alot of other things.
Strange. 

I believe the ITE generic time code has a 1$ clobber bug in it. Here is a
patch to fix this.

--- time.c	Fri Oct  5 10:01:22 2001
+++ /usr/src/linux/arch/mips/ite-boards/generic/time.c	Tue Nov  6 11:38:00 2001
@@ -303,7 +303,8 @@
 			:"r" (timerhi),
 			 "m" (timerlo),
 			 "r" (tmp),
-			 "r" (USECS_PER_JIFFY));
+			 "r" (USECS_PER_JIFFY)
+			:"$1");
 		cached_quotient = quotient;
 	}
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 1$ clobber bug
  2001-11-06 19:44 1$ clobber bug James Simmons
@ 2001-11-06 21:05 ` Ralf Baechle
  0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2001-11-06 21:05 UTC (permalink / raw)
  To: James Simmons; +Cc: linux-mips

On Tue, Nov 06, 2001 at 11:44:20AM -0800, James Simmons wrote:

> Sorry I got the patch backwards. It seems that the standard 2.4.14 tree
> some how missed the $1 clobber fixes but it merged alot of other things.
> Strange. 
> 
> I believe the ITE generic time code has a 1$ clobber bug in it. Here is a
> patch to fix this.

There is no point in a "$1" clobber.

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-11-06 21:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-11-06 19:44 1$ clobber bug James Simmons
2001-11-06 21:05 ` Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2001-11-06 19:19 James Simmons

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox