From: Ralf Baechle <ralf@oss.sgi.com>
To: William Jhun <wjhun@ayrnetworks.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: rm7k flush_icache_line() in rm7k_dma_cache_*
Date: Tue, 16 Apr 2002 00:41:36 -0700 [thread overview]
Message-ID: <20020416004136.A28097@dea.linux-mips.net> (raw)
In-Reply-To: <20020415113844.A21747@ayrnetworks.com>; from wjhun@ayrnetworks.com on Mon, Apr 15, 2002 at 11:38:44AM -0700
On Mon, Apr 15, 2002 at 11:38:44AM -0700, William Jhun wrote:
> We've been experiencing some problems with our RM7k cache code which is
> based on the sgi mm/rm7k.c from around kernel version 2.4.2. While
> trying to track this down, we noticed that someone added a call to
> flush_icache_line() in the rm7k_dma_cache_*() routines (now
> mm/c-rm7k.c). What is the reason for this? It is our understanding that
> the instruction cache does not write back, and so stale cache lines in
> the icache which are later used for data/dma would seem innocuous. Is
> this not true? We could not find a CVS log entry to explain this,
> either. Did anyone experience problems without these calls to
> flush_icache_line()?
All the DMA cache flushes are only supposed to be used from within the
PCI DMA API that is they don't have to deal with instruction caches ever.
As such these flushes are bogus and I'll remove them.
Ralf
prev parent reply other threads:[~2002-04-16 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-15 18:38 rm7k flush_icache_line() in rm7k_dma_cache_* William Jhun
2002-04-16 7:41 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020416004136.A28097@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=linux-mips@oss.sgi.com \
--cc=wjhun@ayrnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox