[RFC][PATCH]

[RFC][PATCH]

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]

Hi!

Please give me a comment on this patch. I'm currently tryin' to make the
HAL2 driver work (yes, I've got my Indy out of the edge again and I'm
going to use it as my desktop machine).

It fixes a compilation problem on dmabuf.c. There, DMA_AUTOINIT isn't
defined. As ./include/asm-mips/dma.h looks like the asm-i386 file in
general, I've copied the #define from the i386 port (and reformated the
passus...).

If you think it'o okay, please apply it (and drop me a note:-p)

MfG, JBG



Index: include/asm-mips/dma.h
===================================================================
RCS file: /cvs/linux/include/asm-mips/dma.h,v
retrieving revision 1.8
diff -u -r1.8 dma.h
--- include/asm-mips/dma.h	2001/09/06 13:12:02	1.8
+++ include/asm-mips/dma.h	2002/06/29 18:23:37
@@ -138,10 +138,11 @@
 #define DMA_PAGE_6              0x89
 #define DMA_PAGE_7              0x8A
 
-#define DMA_MODE_READ	0x44	/* I/O to memory, no autoinit, increment, single mode */
-#define DMA_MODE_WRITE	0x48	/* memory to I/O, no autoinit, increment, single mode */
-#define DMA_MODE_CASCADE 0xC0   /* pass thru DREQ->HRQ, DACK<-HLDA only */
+#define DMA_MODE_READ		0x44	/* I/O to memory, no autoinit, increment, single mode */
+#define DMA_MODE_WRITE		0x48	/* memory to I/O, no autoinit, increment, single mode */
+#define DMA_MODE_CASCADE	0xC0	/* pass thru DREQ->HRQ, DACK<-HLDA only */
 
+#define DMA_AUTOINIT		0x10
 
 extern spinlock_t  dma_spin_lock;
 


-- 
Jan-Benedict Glaw   .   jbglaw@lug-owl.de   .   +49-172-7608481
	 -- New APT-Proxy written in shell script --
	   http://lug-owl.de/~jbglaw/software/ap2/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [RFC][PATCH]

[Ralf Baechle]

On Sat, Jun 29, 2002 at 08:41:29PM +0200, Jan-Benedict Glaw wrote:

> Please give me a comment on this patch. I'm currently tryin' to make the
> HAL2 driver work (yes, I've got my Indy out of the edge again and I'm
> going to use it as my desktop machine).
> 
> It fixes a compilation problem on dmabuf.c. There, DMA_AUTOINIT isn't
> defined. As ./include/asm-mips/dma.h looks like the asm-i386 file in
> general, I've copied the #define from the i386 port (and reformated the
> passus...).
> 
> If you think it'o okay, please apply it (and drop me a note:-p)

Sort of the right thing - why the heck does the Indy sound code have to
rely on code for the that antique PC DMA controller ...

  Ralf

Re: [RFC][PATCH]

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

On Sun, 2002-06-30 14:42:38 +0200, Ralf Baechle <ralf@oss.sgi.com>
wrote in message <20020630144238.A342@dea.linux-mips.net>:
> On Sat, Jun 29, 2002 at 08:41:29PM +0200, Jan-Benedict Glaw wrote:
> > Please give me a comment on this patch. I'm currently tryin' to make the
> > HAL2 driver work (yes, I've got my Indy out of the edge again and I'm
> > going to use it as my desktop machine).
> > 
> > It fixes a compilation problem on dmabuf.c. There, DMA_AUTOINIT isn't
> > defined. As ./include/asm-mips/dma.h looks like the asm-i386 file in
> > general, I've copied the #define from the i386 port (and reformated the
> > passus...).
> > 
> > If you think it'o okay, please apply it (and drop me a note:-p)
> 
> Sort of the right thing - why the heck does the Indy sound code have to
> rely on code for the that antique PC DMA controller ...

Well, OSS has some 'soundbase.o', in which dmabuf.o is linked into.
Possibly which code path is not used at all on Indy, but the #define has
to be there... So there's no real answer, but running 2.4.16 (from
Debian installer) and 'insmod -f'ing the just compiled 2.4.19-rc1 hal2.o
into that kernel ends up in useable sound. So this is some working way
of doing sound.

Btw., I think I'll have a deeper look at hal2.o - the smallest load lets
sound proceed in snail mode:-(

MfG, JBG

-- 
Jan-Benedict Glaw   .   jbglaw@lug-owl.de   .   +49-172-7608481
	 -- New APT-Proxy written in shell script --
	   http://lug-owl.de/~jbglaw/software/ap2/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [RFC][PATCH]

[Ladislav Michl]

On Sun, Jun 30, 2002 at 03:20:20PM +0200, Jan-Benedict Glaw wrote:
> On Sun, 2002-06-30 14:42:38 +0200, Ralf Baechle <ralf@oss.sgi.com>
> wrote in message <20020630144238.A342@dea.linux-mips.net>:
> > On Sat, Jun 29, 2002 at 08:41:29PM +0200, Jan-Benedict Glaw wrote:
> > > Please give me a comment on this patch. I'm currently tryin' to make the
> > > HAL2 driver work (yes, I've got my Indy out of the edge again and I'm
> > > going to use it as my desktop machine).
> > > 
> > > It fixes a compilation problem on dmabuf.c. There, DMA_AUTOINIT isn't
> > > defined. As ./include/asm-mips/dma.h looks like the asm-i386 file in
> > > general, I've copied the #define from the i386 port (and reformated the
> > > passus...).
> > > 
> > > If you think it'o okay, please apply it (and drop me a note:-p)
> > 
> > Sort of the right thing - why the heck does the Indy sound code have to
> > rely on code for the that antique PC DMA controller ...
> 
> Well, OSS has some 'soundbase.o', in which dmabuf.o is linked into.

you need soundcore.o and hal2.o only.

> Possibly which code path is not used at all on Indy, but the #define has
> to be there... So there's no real answer, but running 2.4.16 (from

the real answer is that you are trying to build support for OSS drivers,
which has definitely nothing to do with HAL2 driver. disable it.

> Debian installer) and 'insmod -f'ing the just compiled 2.4.19-rc1 hal2.o
> into that kernel ends up in useable sound. So this is some working way
> of doing sound.
> 
> Btw., I think I'll have a deeper look at hal2.o - the smallest load lets
> sound proceed in snail mode:-(

can you describe it better? (it has always worked for me ;-))

	ladis