[PATCH] REMOTE_DEBUG, DEBUG config cleanup

[PATCH] REMOTE_DEBUG, DEBUG config cleanup

[Jun Sun]

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]


Remove false dependency.  Add help info for CONFIG_DEBUG.

Patches for both 2.4 & 2.5.

Jun

[-- Attachment #2: 030213.a-2.4-debug-config-cleanup.patch --]
[-- Type: text/plain, Size: 1627 bytes --]

diff -Nru linux/Documentation/Configure.help.orig linux/Documentation/Configure.help
--- linux/Documentation/Configure.help.orig	Wed Jan 29 15:32:58 2003
+++ linux/Documentation/Configure.help	Thu Feb 13 12:22:21 2003
@@ -20482,6 +20482,13 @@
   Currently used only by the time services code in the MIPS port.
   Don't turn this on unless you know what you are doing.
 
+Enable run-time debugging
+CONFIG_DEBUG
+  If you say Y here, some debugging macros will do run-time checking.
+  If you say N here, those macros will mostly turn to no-ops.  For
+  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
+  If unsure, say N.
+
 Remote GDB kernel debugging
 CONFIG_REMOTE_DEBUG
   If you say Y here, it will be possible to remotely debug the MIPS
diff -Nru linux/arch/mips/config-shared.in.orig linux/arch/mips/config-shared.in
--- linux/arch/mips/config-shared.in.orig	Thu Feb 13 11:34:55 2003
+++ linux/arch/mips/config-shared.in	Thu Feb 13 12:26:54 2003
@@ -976,10 +976,8 @@
 
 bool 'Are you using a crosscompiler' CONFIG_CROSSCOMPILE
 bool 'Enable run-time debugging' CONFIG_DEBUG
-if [ "$CONFIG_AU1X00_UART" = "y" -o "$CONFIG_ZS" = "y" -o "$CONFIG_SIBYTE_SB1xxx_SOC" = "y" ]; then
-   dep_bool 'Remote GDB kernel debugging' CONFIG_REMOTE_DEBUG $CONFIG_DEBUG
-   dep_bool '  Console output to GDB' CONFIG_GDB_CONSOLE $CONFIG_REMOTE_DEBUG
-fi
+bool 'Remote GDB kernel debugging' CONFIG_REMOTE_DEBUG
+dep_bool '  Console output to GDB' CONFIG_GDB_CONSOLE $CONFIG_REMOTE_DEBUG
 if [ "$CONFIG_SIBYTE_SB1xxx_SOC" = "y" ]; then
    dep_bool 'Compile for Corelis Debugger' CONFIG_SB1XXX_CORELIS $CONFIG_DEBUG
 fi

[-- Attachment #3: 030213.a-2.5-debug-config-cleanup.patch --]
[-- Type: text/plain, Size: 895 bytes --]

diff -Nru linux/arch/mips/Kconfig-shared.orig linux/arch/mips/Kconfig-shared
--- linux/arch/mips/Kconfig-shared.orig	Thu Feb 13 11:37:29 2003
+++ linux/arch/mips/Kconfig-shared	Thu Feb 13 12:26:08 2003
@@ -1547,7 +1547,7 @@
 
 config REMOTE_DEBUG
 	bool "Remote GDB kernel debugging"
-	depends on DEBUG_KERNEL && (AU1000_UART || ZS=y)
+	depends on DEBUG_KERNEL
 	help
 	  If you say Y here, it will be possible to remotely debug the MIPS
 	  kernel using gdb. This enlarges your kernel image disk size by
@@ -1566,6 +1566,12 @@
 config DEBUG
 	bool "Enable run-time debugging"
 	depends on DEBUG_KERNEL
+	help
+	  If you say Y here, some debugging macros will do run-time checking.
+	  If you say N here, those macros will mostly turn to no-ops.  For
+	  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
+	  If unsure, say N.
+
 
 config MAGIC_SYSRQ
 	bool "Magic SysRq key"

Re: [PATCH] REMOTE_DEBUG, DEBUG config cleanup

[Keith Owens]

On Thu, 13 Feb 2003 12:31:08 -0800, 
Jun Sun <jsun@mvista.com> wrote:
>Remove false dependency.  Add help info for CONFIG_DEBUG.
>+Enable run-time debugging
>+CONFIG_DEBUG
>+  If you say Y here, some debugging macros will do run-time checking.
>+  If you say N here, those macros will mostly turn to no-ops.  For
>+  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
>+  If unsure, say N.

CONFIG_DEBUG is too generic for an option that only applies to mips.
Make it CONFIG_MIPS_DEBUG.

Re: [PATCH] REMOTE_DEBUG, DEBUG config cleanup

[Jun Sun]

The hope is some other arches might adopt it too.  How about
CONFIG_RUNTIME_DEBUG?

While we are on the subject, Ralf and I also are thinking to 
change CONFIG_REMOTE_DEBUG to CONFIG_KGDB.  Any objections?

Jun

On Sun, Feb 16, 2003 at 10:59:35AM +1100, Keith Owens wrote:
> On Thu, 13 Feb 2003 12:31:08 -0800, 
> Jun Sun <jsun@mvista.com> wrote:
> >Remove false dependency.  Add help info for CONFIG_DEBUG.
> >+Enable run-time debugging
> >+CONFIG_DEBUG
> >+  If you say Y here, some debugging macros will do run-time checking.
> >+  If you say N here, those macros will mostly turn to no-ops.  For
> >+  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
> >+  If unsure, say N.
> 
> CONFIG_DEBUG is too generic for an option that only applies to mips.
> Make it CONFIG_MIPS_DEBUG.
>