[patch] sys32_sysinfo broken on mips64 and ia64

[patch] sys32_sysinfo broken on mips64 and ia64

[Andrew Clausen]

Hi all,

The sys32_sysinfo() calls are currently using an old version of
"struct sysinfo32", in both the mips64 and ia64 ports.

busybox's init can't cope with the bogus output on my Origin 200,
so this bug prevents the Debian installer from bootstrapping.

This is the mips64 version of the patch.  A very similar patch
could be constructed for ia64... it's very obvious what to do,
so I'll leave it to you ia64 people :)

Cheers,
Andrew


diff -u -r1.42.2.23 linux32.c
--- arch/mips64/kernel/linux32.c	23 Jan 2003 02:12:59 -0000	1.42.2.23
+++ arch/mips64/kernel/linux32.c	20 Feb 2003 00:05:41 -0000
@@ -672,8 +672,11 @@
         u32 bufferram;
         u32 totalswap;
         u32 freeswap;
-        unsigned short procs;
-        char _f[22];
+        u16 procs;
+	u32 totalhigh;
+	u32 freehigh;
+	u32 mem_unit;
+	char _f[8];
 };
 
 extern asmlinkage int sys_sysinfo(struct sysinfo *info);
@@ -698,6 +701,9 @@
 	err |= __put_user (s.totalswap, &info->totalswap);
 	err |= __put_user (s.freeswap, &info->freeswap);
 	err |= __put_user (s.procs, &info->procs);
+	err |= __put_user (s.totalhigh, &info->totalhigh);
+	err |= __put_user (s.freehigh, &info->freehigh);
+	err |= __put_user (s.mem_unit, &info->mem_unit);
 	if (err)
 		return -EFAULT;
 	return ret;

Re: [patch] sys32_sysinfo broken on mips64 and ia64

[Ralf Baechle]

On Thu, Feb 20, 2003 at 11:26:55AM +1100, Andrew Clausen wrote:

> The sys32_sysinfo() calls are currently using an old version of
> "struct sysinfo32", in both the mips64 and ia64 ports.
> 
> busybox's init can't cope with the bogus output on my Origin 200,
> so this bug prevents the Debian installer from bootstrapping.
> 
> This is the mips64 version of the patch.  A very similar patch
> could be constructed for ia64... it's very obvious what to do,
> so I'll leave it to you ia64 people :)

Sigh...  Each time I curse some certain person for copying code from the
ia64 compat code, it was of abysimal quality back in at that time -
unlike the Sparc code.

Will apply ...

  Ralf

Re: [patch] sys32_sysinfo broken on mips64 and ia64

[Maciej W. Rozycki]

On Fri, 21 Feb 2003, Ralf Baechle wrote:

> Sigh...  Each time I curse some certain person for copying code from the
> ia64 compat code, it was of abysimal quality back in at that time -
> unlike the Sparc code.

 Hmm, I think it's well-known the sparc64 port is mature unlike the ia64
one.  So why anyone uses the latter for any real work except the ia64
itself looks like a mystery to me... 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +