From: Ralf Baechle <ralf@linux-mips.org>
To: Juan Quintela <quintela@mandrakesoft.com>
Cc: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>, linux-mips@linux-mips.org
Subject: Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5
Date: Tue, 22 Apr 2003 13:36:42 +0200 [thread overview]
Message-ID: <20030422133642.A15285@linux-mips.org> (raw)
In-Reply-To: <86lly2ixxa.fsf@trasno.mitica>; from quintela@mandrakesoft.com on Tue, Apr 22, 2003 at 01:17:21PM +0200
On Tue, Apr 22, 2003 at 01:17:21PM +0200, Juan Quintela wrote:
> yoichi> +static struct resource vr41xx_pci_mem_resource = {
> yoichi> + "PCI memory space",
> yoichi> + VR41XX_PCI_MEM_START,
> yoichi> + VR41XX_PCI_MEM_END,
> yoichi> + IORESOURCE_MEM
> yoichi> +};
>
> Please, use C99 named initializers in the whole file.
I don't think there's much point in using ISO style initializers everywhere.
So far the convention is only to replace the GNU-style inializer.
We unfortunately have a few places where the code got inflated by at least
the factor of 3 because now some code uses the ISO initializers for
everything - for no good reason.
Ralf
next prev parent reply other threads:[~2003-04-22 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-22 10:11 [patch] TANBAC TB0226(NEC VR4131) for v2.5 Yoichi Yuasa
2003-04-22 11:17 ` Juan Quintela
2003-04-22 11:36 ` Ralf Baechle [this message]
2003-04-22 11:40 ` Geert Uytterhoeven
2003-04-22 12:00 ` Ralf Baechle
2003-04-22 12:15 ` Juan Quintela
2003-04-23 1:31 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030422133642.A15285@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=quintela@mandrakesoft.com \
--cc=yuasa@hh.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox