From: Juan Quintela <quintela@mandrakesoft.com>
To: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5
Date: Tue, 22 Apr 2003 13:17:21 +0200 [thread overview]
Message-ID: <86lly2ixxa.fsf@trasno.mitica> (raw)
In-Reply-To: <20030422191137.4ac88897.yuasa@hh.iij4u.or.jp> (Yoichi Yuasa's message of "Tue, 22 Apr 2003 19:11:37 +0900")
>>>>> "yoichi" == Yoichi Yuasa <yuasa@hh.iij4u.or.jp> writes:
Hi
a couple of comments.
Later, Juan.
yoichi> diff -aruN --exclude=CVS --exclude=.cvsignore linux.orig/arch/mips/vr41xx/tanbac-tb0226/setup.c linux/arch/mips/vr41xx/tanbac-tb0226/setup.c
yoichi> --- linux.orig/arch/mips/vr41xx/tanbac-tb0226/setup.c Thu Jan 1 09:00:00 1970
yoichi> +++ linux/arch/mips/vr41xx/tanbac-tb0226/setup.c Tue Apr 22 17:55:33 2003
yoichi> +
yoichi> +#ifdef CONFIG_PCI
yoichi> +static struct resource vr41xx_pci_io_resource = {
yoichi> + "PCI I/O space",
yoichi> + VR41XX_PCI_IO_START,
yoichi> + VR41XX_PCI_IO_END,
yoichi> + IORESOURCE_IO
yoichi> +};
yoichi> +
yoichi> +static struct resource vr41xx_pci_mem_resource = {
yoichi> + "PCI memory space",
yoichi> + VR41XX_PCI_MEM_START,
yoichi> + VR41XX_PCI_MEM_END,
yoichi> + IORESOURCE_MEM
yoichi> +};
Please, use C99 named initializers in the whole file.
yoichi> +
yoichi> +extern struct pci_ops vr41xx_pci_ops;
yoichi> +
yoichi> +struct pci_channel mips_pci_channels[] = {
yoichi> + {&vr41xx_pci_ops, &vr41xx_pci_io_resource, &vr41xx_pci_mem_resource, 0, 256},
yoichi> + {NULL, NULL, NULL, 0, 0}
yoichi> +};
yoichi> +
yoichi> +struct vr41xx_pci_address_space vr41xx_pci_mem1 = {
yoichi> + VR41XX_PCI_MEM1_BASE,
yoichi> + VR41XX_PCI_MEM1_MASK,
yoichi> + IO_MEM1_RESOURCE_START
yoichi> +};
yoichi> +
yoichi> +struct vr41xx_pci_address_space vr41xx_pci_mem2 = {
yoichi> + VR41XX_PCI_MEM2_BASE,
yoichi> + VR41XX_PCI_MEM2_MASK,
yoichi> + IO_MEM2_RESOURCE_START
yoichi> +};
yoichi> +
yoichi> +struct vr41xx_pci_address_space vr41xx_pci_io = {
yoichi> + VR41XX_PCI_IO_BASE,
yoichi> + VR41XX_PCI_IO_MASK,
yoichi> + IO_PORT_RESOURCE_START
yoichi> +};
yoichi> +
yoichi> +static struct vr41xx_pci_address_map pci_address_map = {
yoichi> + &vr41xx_pci_mem1,
yoichi> + &vr41xx_pci_mem2,
yoichi> + &vr41xx_pci_io
yoichi> +};
yoichi> +#endif
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next prev parent reply other threads:[~2003-04-22 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-22 10:11 [patch] TANBAC TB0226(NEC VR4131) for v2.5 Yoichi Yuasa
2003-04-22 11:17 ` Juan Quintela [this message]
2003-04-22 11:36 ` Ralf Baechle
2003-04-22 11:40 ` Geert Uytterhoeven
2003-04-22 12:00 ` Ralf Baechle
2003-04-22 12:15 ` Juan Quintela
2003-04-23 1:31 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lly2ixxa.fsf@trasno.mitica \
--to=quintela@mandrakesoft.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yuasa@hh.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox