patch: mm/init.c warning

patch: mm/init.c warning

[Kip Walker]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

I know I'm not the first to send something like this... can we please
apply this warning fix for arch/mips/mm/init.c in the non-HIGHMEM case?

thanks,
Kip

[-- Attachment #2: mm_init.diff --]
[-- Type: text/plain, Size: 1014 bytes --]

Index: arch/mips/mm/init.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/mm/init.c,v
retrieving revision 1.38.2.11
diff -u -r1.38.2.11 init.c
--- arch/mips/mm/init.c	23 Apr 2003 15:30:16 -0000	1.38.2.11
+++ arch/mips/mm/init.c	24 Apr 2003 15:46:36 -0000
@@ -151,6 +151,7 @@
 extern char _ftext, _etext, _fdata, _edata;
 extern char __init_begin, __init_end;
 
+#ifdef CONFIG_HIGHMEM
 static void __init fixrange_init (unsigned long start, unsigned long end,
 	pgd_t *pgd_base)
 {
@@ -179,22 +180,25 @@
 		j = 0;
 	}
 }
+#endif
 
 void __init pagetable_init(void)
 {
+#ifdef CONFIG_HIGHMEM
 	unsigned long vaddr;
 	pgd_t *pgd, *pgd_base;
 	pmd_t *pmd;
 	pte_t *pte;
+#endif
 
 	/* Initialize the entire pgd.  */
 	pgd_init((unsigned long)swapper_pg_dir);
 	pgd_init((unsigned long)swapper_pg_dir +
 	         sizeof(pgd_t ) * USER_PTRS_PER_PGD);
 
+#ifdef CONFIG_HIGHMEM
 	pgd_base = swapper_pg_dir;
 
-#ifdef CONFIG_HIGHMEM
 	/*
 	 * Fixed mappings:
 	 */

Re: patch: mm/init.c warning

[Ralf Baechle]

On Thu, Apr 24, 2003 at 08:47:31AM -0700, Kip Walker wrote:

> I know I'm not the first to send something like this... can we please
> apply this warning fix for arch/mips/mm/init.c in the non-HIGHMEM case?

I've applied the patch now - I just never liked it because it's an ugly
#ifdef-o-manis ...

  Ralf