From: ilya@theIlya.com
To: Andrew Clausen <clausen@gnu.org>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: ip32 timer setup fix
Date: Sun, 29 Jun 2003 20:27:25 -0700 [thread overview]
Message-ID: <20030630032725.GL13617@gateway.total-knowledge.com> (raw)
In-Reply-To: <20030630132841.GD480@gnu.org>
Oops! You are right, of course.
it should be
Index: arch/mips/sgi-ip32/ip32-setup.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/sgi-ip32/ip32-setup.c,v
retrieving revision 1.4
diff -u -r1.4 ip32-setup.c
--- arch/mips/sgi-ip32/ip32-setup.c 14 Apr 2003 16:33:24 -0000 1.4
+++ arch/mips/sgi-ip32/ip32-setup.c 30 Jun 2003 03:11:05 -0000
@@ -94,6 +94,7 @@
rtc_ops = &ip32_rtc_ops;
board_be_init = ip32_be_init;
board_time_init = ip32_time_init;
+ board_timer_setup = ip32_timer_setup;
crime_init ();
}
On Mon, Jun 30, 2003 at 01:28:41PM +0000, Andrew Clausen wrote:
> On Sun, Jun 29, 2003 at 08:13:38PM -0700, ilya@theIlya.com wrote:
> > diff -u -r1.4 ip32-setup.c
> > --- arch/mips/sgi-ip32/ip32-setup.c 14 Apr 2003 16:33:24 -0000 1.4
> > +++ arch/mips/sgi-ip32/ip32-setup.c 30 Jun 2003 03:11:05 -0000
> > @@ -94,6 +94,7 @@
> > rtc_ops = &ip32_rtc_ops;
> > board_be_init = ip32_be_init;
> > board_time_init = ip32_time_init;
> > + board_timer_setup = ip32_timer_setup();
> >
> > crime_init ();
> > }
>
> Without even looking at the code... it looks like those () are wrong.
> (Is board_timer_setup a function pointer?) I could be talking
> rubbish of course.
>
> Cheers,
> Andrew
>
next prev parent reply other threads:[~2003-06-30 3:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-30 3:13 ip32 timer setup fix ilya
2003-06-30 13:28 ` Andrew Clausen
2003-06-30 3:27 ` ilya [this message]
2003-06-30 17:06 ` Jun Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030630032725.GL13617@gateway.total-knowledge.com \
--to=ilya@theilya.com \
--cc=clausen@gnu.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox