* 2.4: typo in system.h / __save_and_sti
@ 2003-07-17 12:03 Johannes Stezenbach
2003-07-18 3:21 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Stezenbach @ 2003-07-17 12:03 UTC (permalink / raw)
To: linux-mips
Hi,
I noticed a typo in the (apparently unused) __save_and_sti() macro:
include/asm/system.h (both mips and mips64, linux_2_4 branch):
#define __save_and_sti(x) \
__asm__ __volatile__( \
"__save_and_cli\t%0" \
^^^
: "=r" (x) \
: /* no inputs */ \
: "memory")
Johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.4: typo in system.h / __save_and_sti
2003-07-17 12:03 2.4: typo in system.h / __save_and_sti Johannes Stezenbach
@ 2003-07-18 3:21 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2003-07-18 3:21 UTC (permalink / raw)
To: Johannes Stezenbach, linux-mips
On Thu, Jul 17, 2003 at 02:03:22PM +0200, Johannes Stezenbach wrote:
> I noticed a typo in the (apparently unused) __save_and_sti() macro:
Thanks for noticing this one. Yes, __save_and_sti() seems unused
except by local_irq_set() which itself is unused. The operation it
performs seems to be of little use but anyway, as a pointless exercise
appropriate for 5:20am hacking I fixed it in CVS.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-07-18 3:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-07-17 12:03 2.4: typo in system.h / __save_and_sti Johannes Stezenbach
2003-07-18 3:21 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox