Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH][2.6] add smp.h in processor.h
@ 2004-01-07  3:55 Yoichi Yuasa
  2004-01-07  5:28 ` Ralf Baechle
  0 siblings, 1 reply; 4+ messages in thread
From: Yoichi Yuasa @ 2004-01-07  3:55 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: yuasa, linux-mips

Hello Ralf,

I made a patch for header file of 2.6.

smp_processor_id() is defined in smp.h.
We need adding #include <linux/smp.h> in processor.h.

Please apply this patch.

Yoichi

diff -urN -X dontdiff linux-orig/include/asm-mips/processor.h linux/include/asm-mips/processor.h
--- linux-orig/include/asm-mips/processor.h	2003-12-04 10:52:06.000000000 +0900
+++ linux/include/asm-mips/processor.h	2004-01-07 12:24:25.000000000 +0900
@@ -13,6 +13,7 @@
 
 #include <linux/config.h>
 #include <linux/cache.h>
+#include <linux/smp.h>
 #include <linux/threads.h>
 
 #include <asm/cachectl.h>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][2.6] add smp.h in processor.h
  2004-01-07  3:55 [PATCH][2.6] add smp.h in processor.h Yoichi Yuasa
@ 2004-01-07  5:28 ` Ralf Baechle
  2004-01-07  6:42   ` Yoichi Yuasa
  0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2004-01-07  5:28 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: linux-mips

On Wed, Jan 07, 2004 at 12:55:09PM +0900, Yoichi Yuasa wrote:

> I made a patch for header file of 2.6.
> 
> smp_processor_id() is defined in smp.h.
> We need adding #include <linux/smp.h> in processor.h.

<linux/smp.h> pulls in a fairly large number of other header files which
is why no Linux architecture includes <linux/smp.h> in <asm/processor.h>.
So instead please include the file directly into your code.  In which .c
file you're hitting the problem?

  Ralf

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][2.6] add smp.h in processor.h
  2004-01-07  5:28 ` Ralf Baechle
@ 2004-01-07  6:42   ` Yoichi Yuasa
  2004-01-09  7:40     ` Ralf Baechle
  0 siblings, 1 reply; 4+ messages in thread
From: Yoichi Yuasa @ 2004-01-07  6:42 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: yuasa, linux-mips

On Wed, 7 Jan 2004 06:28:29 +0100
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Wed, Jan 07, 2004 at 12:55:09PM +0900, Yoichi Yuasa wrote:
> 
> > I made a patch for header file of 2.6.
> > 
> > smp_processor_id() is defined in smp.h.
> > We need adding #include <linux/smp.h> in processor.h.
> 
> <linux/smp.h> pulls in a fairly large number of other header files which
> is why no Linux architecture includes <linux/smp.h> in <asm/processor.h>.
> So instead please include the file directly into your code.  In which .c
> file you're hitting the problem?

OK, I made a patch for same problem about vr41xx.
Please apply this patch.

Yoichi

diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/common/bcu.c linux/arch/mips/vr41xx/common/bcu.c
--- linux-orig/arch/mips/vr41xx/common/bcu.c	2003-12-16 10:56:22.000000000 +0900
+++ linux/arch/mips/vr41xx/common/bcu.c	2004-01-07 15:09:06.000000000 +0900
@@ -40,6 +40,7 @@
  *  - Added support for NEC VR4133.
  */
 #include <linux/init.h>
+#include <linux/smp.h>
 #include <linux/types.h>
 
 #include <asm/cpu.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/common/cmu.c linux/arch/mips/vr41xx/common/cmu.c
--- linux-orig/arch/mips/vr41xx/common/cmu.c	2003-10-31 11:29:18.000000000 +0900
+++ linux/arch/mips/vr41xx/common/cmu.c	2004-01-07 15:09:19.000000000 +0900
@@ -40,6 +40,7 @@
  *  - Added support for NEC VR4133.
  */
 #include <linux/init.h>
+#include <linux/smp.h>
 #include <linux/types.h>
 
 #include <asm/cpu.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/common/giu.c linux/arch/mips/vr41xx/common/giu.c
--- linux-orig/arch/mips/vr41xx/common/giu.c	2003-12-16 10:56:22.000000000 +0900
+++ linux/arch/mips/vr41xx/common/giu.c	2004-01-07 15:09:36.000000000 +0900
@@ -42,6 +42,7 @@
 #include <linux/init.h>
 #include <linux/irq.h>
 #include <linux/kernel.h>
+#include <linux/smp.h>
 #include <linux/types.h>
 
 #include <asm/cpu.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/common/icu.c linux/arch/mips/vr41xx/common/icu.c
--- linux-orig/arch/mips/vr41xx/common/icu.c	2003-12-16 10:56:22.000000000 +0900
+++ linux/arch/mips/vr41xx/common/icu.c	2004-01-07 15:09:52.000000000 +0900
@@ -43,6 +43,7 @@
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/smp.h>
 #include <linux/types.h>
 
 #include <asm/cpu.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/common/rtc.c linux/arch/mips/vr41xx/common/rtc.c
--- linux-orig/arch/mips/vr41xx/common/rtc.c	2003-12-02 04:32:01.000000000 +0900
+++ linux/arch/mips/vr41xx/common/rtc.c	2004-01-07 15:10:26.000000000 +0900
@@ -19,6 +19,7 @@
  */
 #include <linux/init.h>
 #include <linux/irq.h>
+#include <linux/smp.h>
 #include <linux/types.h>
 
 #include <asm/io.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/common/serial.c linux/arch/mips/vr41xx/common/serial.c
--- linux-orig/arch/mips/vr41xx/common/serial.c	2003-10-31 11:29:18.000000000 +0900
+++ linux/arch/mips/vr41xx/common/serial.c	2004-01-07 15:10:13.000000000 +0900
@@ -42,6 +42,7 @@
 #include <linux/init.h>
 #include <linux/types.h>
 #include <linux/serial.h>
+#include <linux/smp.h>
 
 #include <asm/addrspace.h>
 #include <asm/cpu.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/tanbac-tb0226/init.c linux/arch/mips/vr41xx/tanbac-tb0226/init.c
--- linux-orig/arch/mips/vr41xx/tanbac-tb0226/init.c	2003-11-25 15:28:19.000000000 +0900
+++ linux/arch/mips/vr41xx/tanbac-tb0226/init.c	2004-01-07 15:10:42.000000000 +0900
@@ -15,6 +15,7 @@
  */
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/smp.h>
 #include <linux/string.h>
 
 #include <asm/bootinfo.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/tanbac-tb0229/init.c linux/arch/mips/vr41xx/tanbac-tb0229/init.c
--- linux-orig/arch/mips/vr41xx/tanbac-tb0229/init.c	2003-11-25 15:28:19.000000000 +0900
+++ linux/arch/mips/vr41xx/tanbac-tb0229/init.c	2004-01-07 15:10:57.000000000 +0900
@@ -20,6 +20,7 @@
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/sched.h>
+#include <linux/smp.h>
 #include <linux/string.h>
 
 #include <asm/bootinfo.h>
diff -urN -X dontdiff linux-orig/arch/mips/vr41xx/zao-capcella/init.c linux/arch/mips/vr41xx/zao-capcella/init.c
--- linux-orig/arch/mips/vr41xx/zao-capcella/init.c	2003-11-25 15:28:19.000000000 +0900
+++ linux/arch/mips/vr41xx/zao-capcella/init.c	2004-01-07 15:11:09.000000000 +0900
@@ -15,6 +15,7 @@
  */
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/smp.h>
 #include <linux/string.h>
 
 #include <asm/bootinfo.h>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][2.6] add smp.h in processor.h
  2004-01-07  6:42   ` Yoichi Yuasa
@ 2004-01-09  7:40     ` Ralf Baechle
  0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2004-01-09  7:40 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: linux-mips

On Wed, Jan 07, 2004 at 03:42:16PM +0900, Yoichi Yuasa wrote:

> > <linux/smp.h> pulls in a fairly large number of other header files which
> > is why no Linux architecture includes <linux/smp.h> in <asm/processor.h>.
> > So instead please include the file directly into your code.  In which .c
> > file you're hitting the problem?
> 
> OK, I made a patch for same problem about vr41xx.
> Please apply this patch.

Applied,

  Ralf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-01-09  7:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-07  3:55 [PATCH][2.6] add smp.h in processor.h Yoichi Yuasa
2004-01-07  5:28 ` Ralf Baechle
2004-01-07  6:42   ` Yoichi Yuasa
2004-01-09  7:40     ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox