* sys32_sched_getaffinity
@ 2004-01-19 19:55 Pavel Kiryukhin
2004-01-20 0:27 ` sys32_sched_getaffinity Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Kiryukhin @ 2004-01-19 19:55 UTC (permalink / raw)
To: linux-mips
Hi,
could anybody give some comments on the following code in 2.4.x -
2.6.1.
sys_sched_getaffinity [kernel/sched.c] on success returns the size of
cpumask_t, which is obviously positive value.
while
sys32_sched_getaffinity [arch/mips/kernel/linux32.c] expect 0 as
successful return from sys_sched_getaffinity.
Would
if (ret > 0) {
be more correct than
if (ret == 0) {
in sys32_sched_getaffinity?
--
Best regards,
Pavel Kiryukhin mailto:vksavl@cityline.ru
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: sys32_sched_getaffinity
2004-01-19 19:55 sys32_sched_getaffinity Pavel Kiryukhin
@ 2004-01-20 0:27 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2004-01-20 0:27 UTC (permalink / raw)
To: Pavel Kiryukhin; +Cc: linux-mips
On Mon, Jan 19, 2004 at 10:55:48PM +0300, Pavel Kiryukhin wrote:
> could anybody give some comments on the following code in 2.4.x -
> 2.6.1.
>
> sys_sched_getaffinity [kernel/sched.c] on success returns the size of
> cpumask_t, which is obviously positive value.
>
> while
>
> sys32_sched_getaffinity [arch/mips/kernel/linux32.c] expect 0 as
> successful return from sys_sched_getaffinity.
Wrong question. The question should be why does the MIPS kernel not use
the generic 32-bit compatibility functions? It now does, I just changed
that.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-01-20 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-19 19:55 sys32_sched_getaffinity Pavel Kiryukhin
2004-01-20 0:27 ` sys32_sched_getaffinity Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox