Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [patch 1/1]  minmax-removal  arch/mips/au1000/common/usbdev.c
@ 2004-09-01 21:28 janitor
       [not found] ` <20040902103407.GC19884@linux-mips.org>
  0 siblings, 1 reply; 2+ messages in thread
From: janitor @ 2004-09-01 21:28 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf, janitor




Patch (against 2.6.8.1) removes unnecessary min/max macros and changes
calls to use kernel.h macros instead.

Since I dont have the hardware those patches are not tested.

Best regards
Veeck

Signed-off-by: Michael Veeck <michael.veeck@gmx.net>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.9-rc1-bk7-max/arch/mips/au1000/common/usbdev.c |    2 --
 1 files changed, 2 deletions(-)

diff -puN arch/mips/au1000/common/usbdev.c~min-max-arch_mips_au1000_common_usbdev arch/mips/au1000/common/usbdev.c
--- linux-2.6.9-rc1-bk7/arch/mips/au1000/common/usbdev.c~min-max-arch_mips_au1000_common_usbdev	2004-09-01 19:38:23.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/arch/mips/au1000/common/usbdev.c	2004-09-01 19:38:23.000000000 +0200
@@ -61,8 +61,6 @@
 #define vdbg(fmt, arg...) do {} while (0)
 #endif
 
-#define MAX(a,b)	(((a)>(b))?(a):(b))
-
 #define ALLOC_FLAGS (in_interrupt () ? GFP_ATOMIC : GFP_KERNEL)
 
 #define EP_FIFO_DEPTH 8

_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/1]  minmax-removal  arch/mips/au1000/common/usbdev.c
       [not found] ` <20040902103407.GC19884@linux-mips.org>
@ 2004-09-02 19:27   ` maximilian attems
  0 siblings, 0 replies; 2+ messages in thread
From: maximilian attems @ 2004-09-02 19:27 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-mips

On Thu, 02 Sep 2004, Ralf Baechle wrote:

> On Wed, Sep 01, 2004 at 11:28:17PM +0200, janitor@sternwelten.at wrote:
> 
> > Patch (against 2.6.8.1) removes unnecessary min/max macros and changes
> > calls to use kernel.h macros instead.
> 
> The patch description isn't really right here; the MAX macro in
> arch/mips/au1000/common/usbdev.c was unused so removing it was a
> nobrainer.

you are right,
sorry it was one of a bigger list of MIN/MAX conversions.
that's no excuse, i'll better double check next time.
 
> > Since I dont have the hardware those patches are not tested.
> 
> I guess that's excusable in this case ;-)

thanks.

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-02 19:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-01 21:28 [patch 1/1] minmax-removal arch/mips/au1000/common/usbdev.c janitor
     [not found] ` <20040902103407.GC19884@linux-mips.org>
2004-09-02 19:27   ` maximilian attems

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox