[PATCH] ip32 build fix

[PATCH] ip32 build fix

[Thiemo Seufer]

Hello All,

a simple build fix for the ip32 framebuffer.


Thiemo


Index: drivers/video/gbefb.c
===================================================================
RCS file: /home/cvs/linux/drivers/video/gbefb.c,v
retrieving revision 1.11
diff -u -p -r1.11 gbefb.c
--- drivers/video/gbefb.c	16 Nov 2004 16:20:39 -0000	1.11
+++ drivers/video/gbefb.c	20 Nov 2004 16:46:58 -0000
@@ -1122,7 +1122,7 @@ static int __init gbefb_probe(struct dev
 
 	if (fb_get_options("gbefb", &option))
 		return -ENODEV;
-	gbefb_setup(options);
+	gbefb_setup(option);
 #endif
 
 	if (!request_mem_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {

Re: [PATCH] ip32 build fix

[Ralf Baechle]

On Sun, Nov 21, 2004 at 03:41:44AM +0100, Thiemo Seufer wrote:

> a simple build fix for the ip32 framebuffer.

Thanks, applied.

  Ralf

Re: [PATCH] ip32 build fix

[Geert Uytterhoeven]

On Sun, 21 Nov 2004, Ralf Baechle wrote:
> On Sun, Nov 21, 2004 at 03:41:44AM +0100, Thiemo Seufer wrote:
> > a simple build fix for the ip32 framebuffer.
> 
> Thanks, applied.

FYI, this has been fixed differently in mainline:

On Fri, 19 Nov 2004, Linux Kernel Mailing List wrote:
| ChangeSet 1.2183, 2004/11/19 14:54:09-08:00, giuseppe@eppesuigoccas.homedns.org
| 
| 	[PATCH] gbefb.c build fix
| 	
| 	The current gbefb.c source cannot be compiled as module because of a small
| 	typo where "option" was written instead of "options" in two places.
| 	
| 	Signed-off-by: Andrew Morton <akpm@osdl.org>
| 	Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| 
| 
| 
|  gbefb.c |    4 ++--
|  1 files changed, 2 insertions(+), 2 deletions(-)
| 
| 
| diff -Nru a/drivers/video/gbefb.c b/drivers/video/gbefb.c
| --- a/drivers/video/gbefb.c	2004-11-19 16:11:11 -08:00
| +++ b/drivers/video/gbefb.c	2004-11-19 16:11:11 -08:00
| @@ -1084,9 +1084,9 @@
|  	int i, ret = 0;
|  
|  #ifndef MODULE
| -	char *option = NULL;
| +	char *options = NULL;
|  
| -	if (fb_get_options("gbefb", &option))
| +	if (fb_get_options("gbefb", &options))
|  		return -ENODEV;
|  	gbefb_setup(options);
|  #endif
| -
| To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
| the body of a message to majordomo@vger.kernel.org
| More majordomo info at  http://vger.kernel.org/majordomo-info.html
| 

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] ip32 build fix

[Ralf Baechle]

On Sun, Nov 21, 2004 at 10:18:26AM +0100, Geert Uytterhoeven wrote:

> FYI, this has been fixed differently in mainline:

Argh, I hat that.  Defining variables in the middle of a block is also
unhealthy ...

  Ralf