Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: "Kevin D. Kissell" <kevink@mips.com>
Cc: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>,
	linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH 2.6.11-rc1] add local_irq_enable() to cpu_idle()
Date: Mon, 17 Jan 2005 22:31:00 +0100	[thread overview]
Message-ID: <20050117213100.GA3026@linux-mips.org> (raw)
In-Reply-To: <41EBEEFA.6040701@mips.com>

On Mon, Jan 17, 2005 at 05:59:38PM +0100, Kevin D. Kissell wrote:

> There have been times when having local_irq_enable() in my idle loop
> would have prevented a hang in some of my experimental kernels, too,
> but it's always been because I had screwed up somewhere else and
> forgotten to re-enable interrupts.  Is there some good reason why
> the kernel should end up in idle with interrupts turned off?

No, never.  It'd result in the scheduler being called with interrupts
disabled which depending if you're lucky or not may happen to reenable
interrupts or not, so you're outside of defined behaviour starting that
point.

  Ralf

  reply	other threads:[~2005-01-17 21:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-17 16:49 [PATCH 2.6.11-rc1] add local_irq_enable() to cpu_idle() Yoichi Yuasa
2005-01-17 16:59 ` Kevin D. Kissell
2005-01-17 21:31   ` Ralf Baechle [this message]
2005-01-18  2:11   ` Yoichi Yuasa
2005-01-19  2:43     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050117213100.GA3026@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=kevink@mips.com \
    --cc=linux-mips@linux-mips.org \
    --cc=yuasa@hh.iij4u.or.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox