Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
Cc: "Kevin D. Kissell" <kevink@mips.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 2.6.11-rc1] add local_irq_enable() to cpu_idle()
Date: Wed, 19 Jan 2005 02:43:19 +0000	[thread overview]
Message-ID: <20050119024319.GA14539@linux-mips.org> (raw)
In-Reply-To: <20050118111159.2b3651aa.yuasa@hh.iij4u.or.jp>

On Tue, Jan 18, 2005 at 11:11:59AM +0900, Yoichi Yuasa wrote:

> "Kevin D. Kissell" <kevink@mips.com> wrote:
> 
> > There have been times when having local_irq_enable() in my idle loop
> > would have prevented a hang in some of my experimental kernels, too,
> > but it's always been because I had screwed up somewhere else and
> > forgotten to re-enable interrupts.  Is there some good reason why
> > the kernel should end up in idle with interrupts turned off?
> 
> After call local_irq_disable(), rest_init()(in init/main.c) calls cpu_idle().

Indeed.  Was looking at a kernel with kdb which removes this line.

  Ralf

      reply	other threads:[~2005-01-19  2:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-17 16:49 [PATCH 2.6.11-rc1] add local_irq_enable() to cpu_idle() Yoichi Yuasa
2005-01-17 16:59 ` Kevin D. Kissell
2005-01-17 21:31   ` Ralf Baechle
2005-01-18  2:11   ` Yoichi Yuasa
2005-01-19  2:43     ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050119024319.GA14539@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=kevink@mips.com \
    --cc=linux-mips@linux-mips.org \
    --cc=yuasa@hh.iij4u.or.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox