From: Ulrich Eckhardt <eckhardt@satorlaser.com>
To: linux-mips@linux-mips.org
Subject: [patch] generate error when trying to compile PCMCIA driver without 64 bit addresses
Date: Wed, 23 Feb 2005 09:47:53 +0100 [thread overview]
Message-ID: <200502230947.53588.eckhardt@satorlaser.com> (raw)
Greetings!
PCMCIA controller registers are mapped in an area that requires the upper four
of the 36 bit addresses, so this can't work without 64 bit physical address
support. Sick thing is that due to some stupid casts the whole thing compiles
without warnings even without 64 bit support but of course doesn't run.
However, that's a topic for a different patch.
Uli
Changes:
* generate error when compiled without 64bit physical address support
---
Index: drivers/pcmcia/au1000_generic.h
===================================================================
RCS file: /home/cvs/linux/drivers/pcmcia/au1000_generic.h,v
retrieving revision 1.4
diff -u -r1.4 au1000_generic.h
--- drivers/pcmcia/au1000_generic.h 19 Oct 2004 07:26:37 -0000 1.4
+++ drivers/pcmcia/au1000_generic.h 23 Feb 2005 08:40:05 -0000
@@ -30,6 +30,10 @@
#include <pcmcia/cistpl.h>
#include "cs_internal.h"
+#if !defined(CONFIG_64BIT_PHYS_ADDR)
+# error "need 64bit physical address support to access PCMCIA controller"
+#endif
+
#define AU1000_PCMCIA_POLL_PERIOD (2*HZ)
#define AU1000_PCMCIA_IO_SPEED (255)
#define AU1000_PCMCIA_MEM_SPEED (300)
next reply other threads:[~2005-02-23 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 8:47 Ulrich Eckhardt [this message]
2005-02-23 11:19 ` [patch] generate error when trying to compile PCMCIA driver without 64 bit addresses Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502230947.53588.eckhardt@satorlaser.com \
--to=eckhardt@satorlaser.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox